Skip to content

Commit

Permalink
Added 'today' postfix to daily feed-in and consumed energy
Browse files Browse the repository at this point in the history
Breaking change:
 - added 'today' postfix to daily feed-in and consumed energy to adhere to the convention used for other sensors.

Attempted to correct failing coverage.
  • Loading branch information
darmach committed Nov 23, 2024
1 parent e74e224 commit 5825dbd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
name: .coverage-${{ matrix.python-version }}
path: .coverage.${{ matrix.python-version }}
if-no-files-found: error
include-hidden-files: true

coverage:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions solax/inverters/x3_hybrid_g4.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ def response_decoder(cls):
"PV Energy total": (pack_u16(80, 81), Total(Units.KWH), div10),
"EPS Energy total": (pack_u16(83, 84), Total(Units.KWH), div10),
"EPS Energy today": (85, DailyTotal(Units.KWH), div10),
"Feed-in Energy": (pack_u16(90, 91), DailyTotal(Units.KWH), div100),
"Consumed Energy": (pack_u16(92, 93), DailyTotal(Units.KWH), div100),
"Feed-in Energy today": (pack_u16(90, 91), DailyTotal(Units.KWH), div100),
"Consumed Energy today": (pack_u16(92, 93), DailyTotal(Units.KWH), div100),
"Feed-in Energy total": (pack_u16(86, 87), Total(Units.KWH), div100),
"Consumed Energy total": (pack_u16(88, 89), Total(Units.KWH), div100),
"Battery Remaining Capacity": (103, Units.PERCENT),
Expand Down
4 changes: 2 additions & 2 deletions tests/samples/expected_values.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@
"PV Energy total": 3.4,
"EPS Energy total": 0.0,
"EPS Energy today": 0.0,
"Feed-in Energy": 0.0,
"Consumed Energy": 2.09,
"Feed-in Energy today": 0.0,
"Consumed Energy today": 2.09,
"Feed-in Energy total": 0.0,
"Consumed Energy total": 20.09,
"Battery Remaining Capacity": 30.0,
Expand Down

0 comments on commit 5825dbd

Please sign in to comment.