Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: remove HERE #1972

Closed
wants to merge 4 commits into from
Closed

Maintenance: remove HERE #1972

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff45ee1
Maintenance: remove HERE
kinkie Dec 28, 2024
e0c62da
Update src/debug/Stream.h
yadij Dec 29, 2024
2042ee4
Merge branch 'master' into here-remove
kinkie Dec 30, 2024
947193d
Empty commit to trigger github check
kinkie Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions scripts/maintenance/HERE-obsolete
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions src/debug/Stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,21 +208,6 @@ void ResyncDebugLog(FILE *newDestination);
/// Outside of debugs() context, has no effect and should not be used.
std::ostream& ForceAlert(std::ostream& s);

/** stream manipulator which does nothing.
* \deprecated Do not add to new code, and remove when editing old code
*
* Its purpose is to inactivate calls made following previous debugs()
* guidelines such as
* debugs(1,2, "some message");
*
* His former objective is now absorbed in the debugs call itself
*/
inline std::ostream&
HERE(std::ostream& s)
{
return s;
}

/*
* MYNAME is for use at debug levels 0 and 1 where HERE is too messy.
yadij marked this conversation as resolved.
Show resolved Hide resolved
*
Expand Down
6 changes: 1 addition & 5 deletions src/tests/stub_cache_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@
#include "tests/STUB.h"

Mgr::Action::Pointer CacheManager::createNamedAction(char const*) STUB_RETVAL(nullptr)
void CacheManager::start(const Comm::ConnectionPointer &, HttpRequest *, StoreEntry *, const AccessLogEntryPointer &)
{
std::cerr << HERE << "\n";
STUB
}
void CacheManager::start(const Comm::ConnectionPointer &, HttpRequest *, StoreEntry *, const AccessLogEntryPointer &) STUB
static CacheManager* instance = nullptr;
CacheManager* CacheManager::GetInstance() STUB_RETVAL(instance)
void Mgr::RegisterAction(char const *, char const *, OBJH *, Protected, Atomic, Format) {}
Expand Down