Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add GitHub Actions workflow for periodic Coverity Scan #1958

Closed
wants to merge 42 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Dec 7, 2024

Implement a weekly scheduled GitHub Actions workflow to run Coverity
Scan (i.e. cov-build). Currently, we run Coverity Scan using Jenkins.

The new job uses the Squid Project pre-made docker image because
installing the tools required to use free Coverity Scan service cannot
be easily automated at the moment.

The job only runs for the official Squid Project repository.

@kinkie
Copy link
Contributor Author

kinkie commented Dec 7, 2024

The build workflow has been tested , as well as the case where secrets are not defined

Unfortunately it's not possible to test the scheduled variant's trigger before landing it because of restrictions of github actions: they only run in the main branch for a repository

Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for advancing this PR.

.github/workflows/scheduled.yaml Outdated Show resolved Hide resolved

on:
schedule:
- cron: "42 3 * * 0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this belated realization convinces you to accept my suggestion, but I still do not have the energy to fight for this specific improvement.

.github/workflows/coverity-scan.yaml Show resolved Hide resolved
.github/workflows/coverity-scan.yaml Outdated Show resolved Hide resolved
.github/workflows/coverity-scan.yaml Outdated Show resolved Hide resolved
.github/workflows/coverity-scan.yaml Outdated Show resolved Hide resolved
.github/workflows/scheduled.yaml Outdated Show resolved Hide resolved
.github/workflows/coverity-scan.yaml Outdated Show resolved Hide resolved
.github/workflows/scheduled.yaml Outdated Show resolved Hide resolved
.github/workflows/coverity-scan.yaml Show resolved Hide resolved
@kinkie kinkie requested a review from rousskov December 12, 2024 22:01
@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Dec 12, 2024
@rousskov rousskov removed their request for review December 12, 2024 22:33
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Dec 12, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Dec 12, 2024 via email

@rousskov rousskov dismissed their stale review December 12, 2024 22:46

My primary concerns have been addressed

@kinkie
Copy link
Contributor Author

kinkie commented Dec 13, 2024

works for me. Clearing for merge

@kinkie kinkie added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) and removed S-waiting-for-author author action is expected (and usually required) labels Dec 13, 2024
@yadij yadij removed the S-could-use-an-approval An approval may speed this PR merger (but is not required) label Dec 16, 2024
squid-anubis pushed a commit that referenced this pull request Dec 16, 2024
Implement a weekly scheduled GitHub Actions workflow to run Coverity
Scan (i.e. cov-build). Currently, we run Coverity Scan using Jenkins.

The new job uses the Squid Project pre-made docker image because
installing the tools required to use free Coverity Scan service cannot
be easily automated at the moment.

The job only runs for the official Squid Project repository.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Dec 16, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants