Y2038: Fix cache_peer connect-timeout reporting #1494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the timeout value in the neighbours cachemgr report is not truncated on systems having 32-bit integers
rousskov
reviewed
Sep 25, 2023
|
I adjusted PR description to better match the proposed fix. Please adjust further as needed. |
rousskov
added
the
S-waiting-for-author
squid-anubis
added
M-failed-other
It will become even better when we replace doneopts hack with a stream manipulator.
rousskov
changed the title
p->connect_timeout_raw = xatoi(token + 16);AFAICT, cache_peer connect-timeout parsing is similarly broken. Fixing that can be considered outside this PR scope, but I am not against adding that fix to this PR. Your call. |
Co-authored-by: Alex Rousskov <[email protected]>
Let's keep this PR as a single focus. Added fixing the parsing to my TODO list |
kinkie
added
S-waiting-for-reviewer
rousskov
approved these changes
Oct 2, 2023
rousskov
added
M-cleared-for-merge
rousskov
reviewed
Oct 2, 2023
rousskov
added
S-waiting-for-author
kinkie
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Oct 3, 2023
... on systems with 64-bit time_t and 32-bit int. Also fixed `htcp=oldsquid` reporting broken since 2015 commit 4ac1880. This fix affects mgr:config and mgr:server_list cache manager reports.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
kinkie
removed
the
backport-to-v6
|
v6 backporting doesn't apply cleanly. Aborting backport |
kinkie
added a commit
to kinkie/squid
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... on systems with 64-bit time_t and 32-bit int.
Also fixed
htcp=oldsquidreporting broken since 2015 commit 4ac1880.This fix affects mgr:config and mgr:server_list cache manager reports.