Mining progress #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ros_answers_miner/cli.py
Outdated
| @@ -1,25 +1,23 @@ | |||
| # -*- coding: utf-8 -*- | |||
| import argparse | |||
|
|
|||
| from .parser import url_to_question | |||
| from ros_answers_miner.parser import url_to_question | |||
There was a problem hiding this comment.
relative imports are better here; I'd switch back to the original version of the line unless there's a strong reason for the change?
src/ros_answers_miner/cli.py
Outdated
|
|
||
| def main() -> None: | ||
| parser = argparse.ArgumentParser('ros-answers-miner') | ||
| subparsers = parser.add_subparsers() | ||
|
|
||
| p = subparsers.add_parser( | ||
| 'scrape', | ||
| help='extracts information from a given ROS Answers question URL') | ||
| 'scrap', |
|
|
||
| import attr | ||
| class User: |
There was a problem hiding this comment.
Just use attrs or a dataclass instead.
| } | ||
|
|
||
|
|
||
| class Comment: |
There was a problem hiding this comment.
again, prefer attrs or a data class
|
|
||
|
|
||
| @attr.s(auto_attribs=True) | ||
| class Answer: |
There was a problem hiding this comment.
Why was attrs dropped?
src/ros_answers_miner/models.py
Outdated
| comments: OrderedSet[Comment] | ||
| answers: OrderedSet[Answer] | ||
|
|
||
| def __init__(self, url, date, votes, views, user, title, content, tags, comments, answers): |
There was a problem hiding this comment.
Again, this is why attrs exists! Don't roll your own init, hash, cmp, eq, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mining of a Question in ROS Answers: