v2.0

squadracorsepolito · Apr 30, 2024 · 0a6be4c · 0a6be4c
1 parent 3fe004d
commit 0a6be4c
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -37,17 +37,18 @@ jobs:
       matrix:
         include:
           - os: macos-latest
+            # MEMO TODO: Add version number to the app name, zip does not supports dots, you have to use - instead
             TARGET: macos
             CMD_BUILD: >
-                pyinstaller -F -w -n SerialToUdpTranslator-${{ github.ref_name }}-Mac-x64 -i resources/icon.icns main.py &&
+                pyinstaller -F -w -n SerialToUdpTranslator-Mac-x64 -i resources/icon.icns main.py &&
                 cd dist/ &&
-                zip -r9 SerialToUdpTranslator-${{ github.ref_name }}-Mac-x64 SerialToUdpTranslator-${{ github.ref_name }}-Mac-x64.app/                
-            OUT_FILE_NAME: SerialToUdpTranslator-${{ github.ref_name }}-Mac-x64.zip
+                zip -r9 SerialToUdpTranslator-Mac-x64 SerialToUdpTranslator-Mac-x64.app/                
+            OUT_FILE_NAME: SerialToUdpTranslator-Mac-x64.zip
             ASSET_MIME: application/zip
           - os: windows-latest
             TARGET: windows
             CMD_BUILD: pyinstaller -F -w -n SerialToUdpTranslator-${{ github.ref_name }}-Win-x64 -i resources/icon.ico main.py
-            OUT_FILE_NAME: SerialToUdpTranslator-Win-${{ github.ref_name }}-x64.exe
+            OUT_FILE_NAME: SerialToUdpTranslator-${{ github.ref_name }}-Win-x64.exe
             ASSET_MIME: application/vnd.microsoft.portable-executable
           - os: ubuntu-latest
             TARGET: linux