Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(golang): escape q field name #3647

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

vitords
Copy link
Contributor

@vitords vitords commented Oct 9, 2024

Adds q to the reserve keywords.

Although not a golang keyword per se, it works as one since q is reserved as a shorthand for Queries in the generated code so there's no need to rename the reserved keywords list.

Fixes #3627.

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've been meaning to fix this for a while.

@kyleconroy kyleconroy merged commit 10dd388 into sqlc-dev:main Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid go generated code when there's only one field and it's named "q"
2 participants