Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix german blocklist #5

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix german blocklist #5

merged 1 commit into from
Nov 29, 2023

Conversation

mgred
Copy link

@mgred mgred commented Nov 28, 2023

replace non offensive word deich. This seems to be a wrong translation from dyke which means levee. It can also mean lesbe, that describes a female homosexual person.

replace non offensive word
@mgred
Copy link
Author

mgred commented Nov 28, 2023

I ran cargo run and included the output in the PR, that seems to be wrong isn't it?

@4kimov
Copy link
Member

4kimov commented Nov 28, 2023

Thank you @mgred, much appreciated. No, the changed files look correct. Is there something that you see should be adjusted before I merge?

@mgred
Copy link
Author

mgred commented Nov 29, 2023

@4kimov I'm concerned, because the pull request adding the indonesian blocklist did not include the generated output files and the updated combined blocklist.json. These changes are included in this PR, as well. I think we have to generate the outputs including the indonesian files first before we can merge this.

@mgred
Copy link
Author

mgred commented Nov 29, 2023

I created a PR that adds output/id.json and updates output/blocklist.json with the indonesian wordlist.

@4kimov
Copy link
Member

4kimov commented Nov 29, 2023

Ah, I see! Thank you for elaborating.

No, the programmatically generated output doesn't matter yet in the next branch, because at this point the most important (and hardest) thing is to gather appropriate lists. The output will be generated / cleaned up either way sooner or later.

Good eye tho 👍

@4kimov 4kimov merged commit dc1e4a1 into sqids:next Nov 29, 2023
1 check passed
@mgred mgred deleted the fix-german-list branch November 29, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants