Merge pull request #1663 from spryker-shop/feature/frw-9281/dev-adjus…

…ted-project-level-cs-rules

Feature/frw 9281/dev adjusted project level cs rules

config/Shared/common/config_logs-ci-errors.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Monolog\Logger;
 use Spryker\Shared\Log\LogConstants;
 

config/Shared/common/config_logs-ci-info.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\Event\EventConstants;
 use Spryker\Shared\Log\LogConstants;
 use Spryker\Shared\Propel\PropelConstants;

config/Shared/common/config_logs-files.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\Event\EventConstants;
 use Spryker\Shared\Log\LogConstants;
 use Spryker\Shared\Propel\PropelConstants;

config/Shared/common/config_oauth.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\Http\HttpConstants;
 use Spryker\Shared\Oauth\OauthConstants;
 use Spryker\Shared\OauthCryptography\OauthCryptographyConstants;

config/Shared/common/config_oms-development.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\DummyMarketplacePayment\DummyMarketplacePaymentConfig;
 use Spryker\Shared\DummyPayment\DummyPaymentConfig;
 use Spryker\Shared\Kernel\KernelConstants;

config/Shared/config_default-ci.mysql.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\Propel\PropelConstants;
 use Spryker\Shared\StorageDatabase\StorageDatabaseConfig;
 use Spryker\Shared\StorageDatabase\StorageDatabaseConstants;

config/Shared/config_default-ci.pgsql.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\Propel\PropelConstants;
 use Spryker\Shared\StorageDatabase\StorageDatabaseConfig;
 use Spryker\Shared\StorageDatabase\StorageDatabaseConstants;

config/Shared/config_default-ci.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Monolog\Logger;
 use Pyz\Shared\Console\ConsoleConstants;
 use Spryker\Shared\AppCatalogGui\AppCatalogGuiConstants;

config/Shared/config_default-docker.acp.dev.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\AppCatalogGui\AppCatalogGuiConstants;
 use Spryker\Shared\Kernel\KernelConstants;
 use Spryker\Shared\Store\StoreConstants;

config/Shared/config_default-docker.ci.cypress.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 // ############################################################################
 // ########################## CI CYPRESS CONFIGURATION ########################
 // ############################################################################

config/Shared/config_default-docker.ci.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 // ############################################################################
 // ############################## CI CONFIGURATION ############################
 // ############################################################################

config/Shared/config_default-docker.dev.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Monolog\Logger;
 use Pyz\Shared\Console\ConsoleConstants;
 use Spryker\Shared\Api\ApiConstants;

config/Shared/config_default-docker.dms-testing.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Monolog\Logger;
 use Spryker\Shared\Api\ApiConstants;
 use Spryker\Shared\Application\ApplicationConstants;

config/Shared/config_default-docker.prod.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\Application\ApplicationConstants;
 use SprykerShop\Shared\ShopApplication\ShopApplicationConstants;
 

config/Shared/config_default.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Generated\Shared\Transfer\AddPaymentMethodTransfer;
 use Generated\Shared\Transfer\AddReviewsTransfer;
 use Generated\Shared\Transfer\AppConfigUpdatedTransfer;
@@ -279,7 +281,7 @@
         getenv('SPRYKER_OAUTH_KEY_PUBLIC') ?: '',
     ) ?: null;
 $config[OauthConstants::ENCRYPTION_KEY] = getenv('SPRYKER_OAUTH_ENCRYPTION_KEY') ?: null;
-$config[OauthConstants::OAUTH_CLIENT_CONFIGURATION] = json_decode(getenv('SPRYKER_OAUTH_CLIENT_CONFIGURATION'), true) ?: [];
+$config[OauthConstants::OAUTH_CLIENT_CONFIGURATION] = getenv('SPRYKER_OAUTH_CLIENT_CONFIGURATION') ? json_decode(getenv('SPRYKER_OAUTH_CLIENT_CONFIGURATION'), true) : [];
 
 // >> ZED REQUEST
 
@@ -413,7 +415,7 @@
 // >>> STORAGE
 
 $keyValueRegionNamespaces = json_decode(getenv('SPRYKER_KEY_VALUE_REGION_NAMESPACES') ?: '[]', true);
-$config[StorageConstants::STORAGE_KV_SOURCE] = strtolower(getenv('SPRYKER_KEY_VALUE_STORE_ENGINE')) ?: 'redis';
+$config[StorageConstants::STORAGE_KV_SOURCE] = getenv('SPRYKER_KEY_VALUE_STORE_ENGINE') ? strtolower(getenv('SPRYKER_KEY_VALUE_STORE_ENGINE')) : 'redis';
 $config[StorageRedisConstants::STORAGE_REDIS_PERSISTENT_CONNECTION] = true;
 $config[StorageRedisConstants::STORAGE_REDIS_SCHEME] = getenv('SPRYKER_KEY_VALUE_STORE_PROTOCOL') ?: 'tcp';
 $config[StorageRedisConstants::STORAGE_REDIS_HOST] = getenv('SPRYKER_KEY_VALUE_STORE_HOST');

config/Shared/config_local.dist.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Pyz\Shared\Console\ConsoleConstants;
 
 /*

config/Shared/config_propel.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 use Spryker\Shared\Propel\PropelConstants;
 use Spryker\Zed\Propel\PropelConfig;
 use Spryker\Zed\PropelOrm\Business\Builder\ExtensionObjectBuilder;

config/Shared/console_env_local.dist.php

@@ -1,3 +1,5 @@
 <?php
 
+declare(strict_types = 1);
+
 return 'development';

config/Shared/default_store.php

@@ -1,3 +1,5 @@
 <?php
 
+declare(strict_types = 1);
+
 return 'DE';

config/Shared/stores.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 $stores = [];
 
 if (getenv('SPRYKER_ACTIVE_STORES')) {

config/Zed/cronjobs/jenkins.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 /*
  * Notes:
  *

phpcs.xml

@@ -22,13 +22,16 @@
     <exclude-pattern>*/tests/_output/*</exclude-pattern>
     <exclude-pattern>*/tests/*/_data/*</exclude-pattern>
 
-    <rule ref="vendor/spryker/code-sniffer/Spryker/ruleset.xml"/>
-
-    <rule ref="vendor/spryker/code-sniffer/SprykerStrict/ruleset.xml">
-        <exclude name="SprykerStrict.TypeHints.ParameterTypeHint"/>
-        <exclude name="SprykerStrict.TypeHints.PropertyTypeHint"/>
+    <rule ref="vendor/spryker/code-sniffer/Spryker/ruleset.xml">
+        <exclude name="Spryker.Commenting.DocBlock"/>
+        <exclude name="Spryker.Commenting.DocBlockConst"/>
+        <exclude name="Spryker.Commenting.InlineDocBlock"/>
+        <exclude name="Spryker.Commenting.DocBlockApiAnnotation"/>
+        <exclude name="Spryker.Commenting.DocBlockReturnVoid"/>
     </rule>
 
+    <rule ref="vendor/spryker/code-sniffer/SprykerStrict/ruleset.xml"/>
+
     <!-- Define your own sniffs here -->
 
     <rule ref="Spryker.Internal.SprykerDisallowFunctions">
@@ -56,5 +59,17 @@
     <rule ref="SlevomatCodingStandard.Functions.DisallowTrailingCommaInClosureUse">
         <severity>0</severity>
     </rule>
+    <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes"/>
+    <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators"/>
+    <rule ref="SlevomatCodingStandard.ControlStructures.EarlyExit"/>
+    <rule ref="SlevomatCodingStandard.PHP.OptimizedFunctionsWithoutUnpacking"/>
+    <rule ref="SlevomatCodingStandard.PHP.UselessSemicolon"/>
+    <rule ref="SlevomatCodingStandard.Variables.DisallowSuperGlobalVariable"/>
+    <rule ref="SlevomatCodingStandard.Variables.UselessVariable"/>
+    <rule ref="SlevomatCodingStandard.ControlStructures.UselessTernaryOperator"/>
+    <rule ref="SlevomatCodingStandard.Functions.UnusedParameter"/>
+    <rule ref="SlevomatCodingStandard.Variables.UnusedVariable"/>
+
+    <!-- Define your own sniffs here -->
 
 </ruleset>

src/Orm/Zed/Acl/Persistence/SpyAclGroup.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclGroup as BaseSpyAclGroup;

src/Orm/Zed/Acl/Persistence/SpyAclGroupArchive.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclGroupArchive as BaseSpyAclGroupArchive;

src/Orm/Zed/Acl/Persistence/SpyAclGroupArchiveQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclGroupArchiveQuery as BaseSpyAclGroupArchiveQuery;

src/Orm/Zed/Acl/Persistence/SpyAclGroupQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclGroupQuery as BaseSpyAclGroupQuery;

src/Orm/Zed/Acl/Persistence/SpyAclGroupsHasRoles.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclGroupsHasRoles as BaseSpyAclGroupsHasRoles;

src/Orm/Zed/Acl/Persistence/SpyAclGroupsHasRolesQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclGroupsHasRolesQuery as BaseSpyAclGroupsHasRolesQuery;

src/Orm/Zed/Acl/Persistence/SpyAclRole.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRole as BaseSpyAclRole;

src/Orm/Zed/Acl/Persistence/SpyAclRoleArchive.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRoleArchive as BaseSpyAclRoleArchive;

src/Orm/Zed/Acl/Persistence/SpyAclRoleArchiveQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRoleArchiveQuery as BaseSpyAclRoleArchiveQuery;

src/Orm/Zed/Acl/Persistence/SpyAclRoleQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRoleQuery as BaseSpyAclRoleQuery;

src/Orm/Zed/Acl/Persistence/SpyAclRule.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRule as BaseSpyAclRule;

src/Orm/Zed/Acl/Persistence/SpyAclRuleArchive.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRuleArchive as BaseSpyAclRuleArchive;

src/Orm/Zed/Acl/Persistence/SpyAclRuleArchiveQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRuleArchiveQuery as BaseSpyAclRuleArchiveQuery;

src/Orm/Zed/Acl/Persistence/SpyAclRuleQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclRuleQuery as BaseSpyAclRuleQuery;

src/Orm/Zed/Acl/Persistence/SpyAclUserHasGroup.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclUserHasGroup as BaseSpyAclUserHasGroup;

src/Orm/Zed/Acl/Persistence/SpyAclUserHasGroupQuery.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\Acl\Persistence;
 
 use Spryker\Zed\Acl\Persistence\Propel\AbstractSpyAclUserHasGroupQuery as BaseSpyAclUserHasGroupQuery;

src/Orm/Zed/AclEntity/Persistence/SpyAclEntityRule.php

@@ -5,6 +5,8 @@
  * For full license information, please view the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types = 1);
+
 namespace Orm\Zed\AclEntity\Persistence;
 
 use Orm\Zed\AclEntity\Persistence\Base\SpyAclEntityRule as BaseSpyAclEntityRule;