feat: Add e2e testing #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj52951
requested review from
mpetrunic,
tcar121293,
mpetrun5,
MakMuftic and
saadahmsiddiqui
mpetrun5
previously approved these changes
Dec 13, 2024
mpetrun5
requested changes
Dec 16, 2024
tcar121293
requested changes
Dec 16, 2024
| @@ -0,0 +1,7 @@ | |||
| DB_NAME=squid | |||
There was a problem hiding this comment.
Could we add .env to gitignore
There was a problem hiding this comment.
.env is used for interpolation in docker-compose.yml so it is needed. Same as ./envs files are needed inside containers.
mpetrun5
approved these changes
Dec 17, 2024
tcar121293
requested changes
Dec 17, 2024
tcar121293
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added e2e tests for the whole indexing functionality. Also set up the testing environment in
docker-compose.yml.closes #10