Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache 'effective' Docket instance in DefaultAsyncApiDocketService #411

Closed

Conversation

tvahrst
Copy link
Contributor

@tvahrst tvahrst commented Oct 18, 2023

This PR solves #409 .

On first invocation of DefaultAsyncApiDocketService#getAsyncApiDocket(), the service caches the resulting docket instance.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for springwolf-ui ready!

Name Link
🔨 Latest commit 70c9e35
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/653373e51757880007a22fbf
😎 Deploy Preview https://deploy-preview-411--springwolf-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sam0r040 sam0r040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvahrst I like the change, but it would be great if you provide a unit test for the new behavior. Thanks!

@timonback
Copy link
Member

PR is superseeded with #421

Please enable:
Screenshot 2023-10-27 at 15 34 18

@timonback timonback closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants