Predbat mode #420
Predbat mode #420
Conversation
| self.calculate_best_charge = True | ||
| self.calculate_best_discharge = True | ||
| self.set_charge_window = True | ||
| else: # PREDBAT_MODE_OPTIONS[PREDBAT_MODE_MONITOR] |
There was a problem hiding this comment.
Personally I'd make this an explicit elif, followed by an else that throws an error due to an unexpected mode, so it's safer in the future if you add other values to the mode.
Or is this else primarily the mechanism to set the mode to MONITOR if no mode is currently set?
|
Also, the mode dropdown doesn't appear in the auto entities card, it'd be good to coordinate with the person who build that to add another section for it (or maybe add it manually at the top of that card alongside the status). |
|
Now I've got it running and checked it out more, I also thought that the docs for the SOC only section don't make it clear (to me at least) what the benefit is of this mode, I couldn't figure why I'd want it to adjust the target percentage - but I expect there is a reason that you understand :) https://springfall2008.github.io/batpred/customisation/#predbat-control-soc-only-mode |
|
And I think I would have had the mode options in a different order, with Monitor, Charge and Discharge, Charge, SOC - the first one for the default starting value, then the others in what I guess is reducing order of likeliness of selection. Not a big deal, just may be a tad more usable. |
No description provided.