Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT Code style automation PLEASE DO NOT MERGE #312

Merged
merged 29 commits into from
Nov 27, 2023

Conversation

iainfogg
Copy link
Collaborator

@iainfogg iainfogg commented Nov 11, 2023

This closes issue #313 .

I suggest we use the issue for discussing what standards etc. that we want, then use this PR to review the actual implementation, to try and keep it cleaner.

@iainfogg iainfogg changed the title Code style automation DRAFT Code style automation Nov 11, 2023
@iainfogg iainfogg marked this pull request as draft November 11, 2023 20:01
@iainfogg iainfogg changed the title DRAFT Code style automation Code style automation Nov 11, 2023
@iainfogg iainfogg changed the title Code style automation DRAFT Code style automation Nov 11, 2023
@iainfogg
Copy link
Collaborator Author

iainfogg commented Nov 21, 2023

@springfall2008 I think this is ready to go now - once you've approved this, I will do a PR on main to fix any issues which these checks find, so that you have clean branch BEFORE we merge this in to main. As a result, I'm leaving this as DRAFT so this doesn't accidentally get merged in until after that's been done.

Also, this relies on that pre-commit.com/lite thing being set up on your repo.

@iainfogg iainfogg changed the title DRAFT Code style automation DRAFT Code style automation PLEASE DO NOT MERGE Nov 27, 2023
@iainfogg iainfogg marked this pull request as ready for review November 27, 2023 20:35
@iainfogg
Copy link
Collaborator Author

I'm taking this one out of draft @springfall2008 , but please don't merge this one. I'm trying to test out the standards checking running on your repo.

@iainfogg iainfogg changed the base branch from main to code-style November 27, 2023 20:39
@iainfogg
Copy link
Collaborator Author

@springfall2008 I'm merging this from the code-style branch in my repo to a branch of the same name in your repo, to test out the code style pipeline. This isn't putting it into main any more (I'll do that separately another time).

@iainfogg iainfogg merged commit 5def2a3 into springfall2008:code-style Nov 27, 2023
@iainfogg iainfogg mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants