Code cleanup (#656)

* refactor: clean up code for efficiencies and readability

* refactor: clean up code for efficiencies and readability

* refactor: sorted imports

* [pre-commit.ci lite] apply automatic fixes

* refactor: update cspell dict

* refactor: add fstring

* [pre-commit.ci lite] apply automatic fixes

* refactor: cspell dictionary update

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

.cspell/custom-dictionary-workspace.txt

@@ -6,6 +6,8 @@ apexcharts
 appdaemon
 appkey
 argname
+autodocstring
+autoflake
 automations
 autopep
 autoupdate
@@ -38,6 +40,7 @@ dstart
 dwindow
 elif
 endt
+firstparty
 futurerate
 gekey
 geserial
@@ -61,6 +64,7 @@ ivtime
 Krakenflex
 kwhb
 linebreak
+localfolder
 lockstep
 markdownlint
 maximise
@@ -75,8 +79,10 @@ mkdocs
 Modbus
 mqtt
 myenergi
+mypy
 nattribute
 nearr
+njpwerner
 nord
 Nordpool
 octoplus
@@ -109,13 +115,16 @@ SolarEdge
 Solax
 Solcast
 solisx
+sourcery
 Southwell
 springfall
 startt
+stdlib
 stepline
 tasmota
 tdata
 tdiff
+thirdparty
 timea
 timeb
 timec
@@ -127,6 +136,7 @@ timezone
 Trefor
 treforsiphone
 unstaged
+venv
 Wallbox
 welink
 xaxis

.devcontainer/devcontainer.json

@@ -4,27 +4,36 @@
 	"name": "Python 3",
 	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
 	"image": "mcr.microsoft.com/devcontainers/python:0-3.11",
-
 	// Features to add to the dev container. More info: https://containers.dev/features.
 	// "features": {},
-
 	// Configure tool-specific properties.
 	"customizations": {
 		// Configure properties specific to VS Code.
 		"vscode": {
-			"settings": {},
+			"settings": {
+				"files.eol": "\n",
+                "editor.tabSize": 4,
+				"[python]": {
+                    "diffEditor.ignoreTrimWhitespace": false,
+                    "editor.defaultFormatter": "ms-python.black-formatter",
+                    "editor.formatOnSave": true
+                }
+			},
 			"extensions": [
 				"ms-python.python",
+                "ms-python.black-formatter",
+                "ms-python.isort",
+                "ms-python.flake8",
+				"sourcery.sourcery",
+				"njpwerner.autodocstring",
 				"streetsidesoftware.code-spell-checker",
 				"bierner.markdown-preview-github-styles",
 				"DavidAnson.vscode-markdownlint"
 			]
 		}
 	},
-
 	// Use 'forwardPorts' to make a list of ports inside the container available locally.
 	// "forwardPorts": [9000],
-
 	// Use 'portsAttributes' to set default properties for specific forwarded ports.
 	// More info: https://containers.dev/implementors/json_reference/#port-attributes
 	// "portsAttributes": {
@@ -33,15 +42,12 @@
 	// 		"onAutoForward": "notify"
 	// 	}
 	// },
-
 	// Passthrough of SSH key to devcontainer
 	"mounts": [
 		"type=bind,source=/home/${localEnv:USER}/.ssh,target=/home/vscode/.ssh,readonly"
 	],
-
 	// Use 'postCreateCommand' to run commands after the container is created.
 	"postCreateCommand": "pip install --upgrade pip && pip3 install -r requirements.txt"
-
 	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
 	// "remoteUser": "root"
 }

.flake8

@@ -0,0 +1,9 @@
+[flake8]
+max-line-length = 180
+max-complexity = 15
+exclude = build/*
+extend-ignore =
+    # see https://github.com/PtCQA/pycodestyle/issues/373
+    E203,
+ignore = E203, E266, E501, W503, W605
+select = B,C,E,F,W,T4