Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly render NOT. #1659

Closed
wants to merge 2 commits into from
Closed

Properly render NOT. #1659

wants to merge 2 commits into from

Conversation

schauder
Copy link
Contributor

@schauder schauder commented Nov 8, 2023

Closes #1653

@schauder schauder force-pushed the issue/1653-where-not branch from 63dd114 to edde547 Compare November 8, 2023 14:07
@schauder schauder requested a review from mp911de November 8, 2023 14:08
@schauder schauder force-pushed the issue/1653-where-not branch 2 times, most recently from 4503e91 to e5cdc46 Compare November 9, 2023 11:03
@mp911de mp911de added the type: bug A general bug label Nov 10, 2023
@mp911de mp911de added this to the 3.1.6 (2023.0.6) milestone Nov 14, 2023
mp911de pushed a commit that referenced this pull request Nov 14, 2023
@schauder @mp911de
Properly render NOT condition.
c73523a 
Closes #1653
Original pull request: #1659
mp911de added a commit that referenced this pull request Nov 14, 2023
@mp911de
Polishing.
bb20c66 
Introduce prefix operator to express queries as Conditions.not(…) as alternative to myCondition.not() (suffix operator) for easier readability.

Reformat code, update copyright years.

See #1653
Original pull request: #1659
mp911de pushed a commit that referenced this pull request Nov 14, 2023
@schauder @mp911de
Properly render NOT condition.
97b4154 
Closes #1653
Original pull request: #1659
mp911de added a commit that referenced this pull request Nov 14, 2023
@mp911de
Polishing.
99e5142 
Introduce prefix operator to express queries as Conditions.not(…) as alternative to myCondition.not() (suffix operator) for easier readability.

Reformat code, update copyright years.

See #1653
Original pull request: #1659
@mp911de mp911de closed this Nov 14, 2023
@mp911de
Copy link
Member

mp911de commented Nov 14, 2023

That's merged and backported now.

@mp911de mp911de deleted the issue/1653-where-not branch November 14, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.6 (2023.0.6)
Development

Successfully merging this pull request may close these issues.

Incorrect query generated when not Condition is applied on Where clause of Select statement
2 participants
@schauder @mp911de