Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Artemis tests on Java 23 #41911

Closed
wants to merge 1 commit into from
Closed

Disable Artemis tests on Java 23 #41911

wants to merge 1 commit into from

Conversation

cms04
Copy link
Contributor

@cms04 cms04 commented Aug 16, 2024

I completely disabled the following test on Java 23:

  • ArtemisAutoConfigurationTests
  • ArtemisEmbeddedConfigurationFactoryTests
  • ArtemisEnvironmentTests
  • JmsHealthContributorAutoConfigurationTests

Besides that I disabled the tests with Artemis context in the following test class:

  • JmsAutoConfigurationTests

Because the org.junit.jupiter.api.condition.JRE does not contain a JAVA_23 enum value yet, I used the @EnabledForJreRange annotation and not the @DisabledOnJre annotation.

This should close #41909

The reason for this is that Artemis is not compatible yet with Java 23:
https://issues.apache.org/jira/browse/ARTEMIS-4975

The following test classes are completely disabled on Java 23:
- ArtemisAutoConfigurationTests
- ArtemisEmbeddedConfigurationFactoryTests
- ArtemisEnvironmentTests
- JmsHealthContributorAutoConfigurationTests

Besides that I disabled the tests with Artemis context in the
following test class:
- JmsAutoConfigurationTests

Because the org.junit.jupiter.api.condition.JRE does not contain a
JAVA_23 enum value yet, I used the EnabledForJreRange annotation and
not the DisabledOnJre annotation.

This should close #41909
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 16, 2024
@wilkinsona
Copy link
Member

Thanks, @cms04, but this is broader than hopefully necessary. As far as we know, it's only ArtemisAutoConfigurationTests that's affected and we just need to adapt its condition know that we've upgraded to a version of JUnit Jupiter where JRE.OTHER no longer matches Java 23. If you're interested, please see #41909 (comment) for a longer explanation of what was happening.

@wilkinsona wilkinsona closed this Aug 19, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 19, 2024
@cms04 cms04 deleted the 41909/disable_artemis_tests_on_java_23 branch August 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using JRE.OTHER when disabling Artemis tests to work around ARTEMIS-4975
3 participants