Refactor ClinicServiceImpl #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arey
reviewed
Aug 19, 2024
src/main/java/org/springframework/samples/petclinic/service/ClinicServiceImpl.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
thought: it seems, there are a lot of reformatting for converting tab to spaces according to the .editorconfig
|
I've added commit for Issue #144 there, @arey |
thisdudkin
changed the title
|
Thanks a lot Alexander :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes all fields in the
ClinicServiceImplclassfinalto ensure they are immutable after initialization. It also removes some redundant imports.Changes
Made fields in
ClinicServiceImplfinal.Updated the constructor to initialize these fields.
Removed unnecessary imports.
UPD: added private helper method to extract common entity retrieval logic