Replace Consul HTTP Client with Interface Clients #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate health indicator to new http client
Create placeholder model objects for new client
Add more models to support new http client
Add SSL configuration support for Consul Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #475, Consul token query parameter deprecated in Consul 1.17 however the current Consul HTTP client seems to be no longer maintained.
Moving to interface clients also has the added benefit for allowing for blocking and non-blocking clients to be used.
Further to this change, the docker image used for integration testing this lib is using an outdated image: https://hub.docker.com/_/consul and does not have the latest consul images so this needed to be moved to https://hub.docker.com/r/hashicorp/consul.
Any suggestions are VERY welcome, I assume this only as a first draft for this change so have only migrated the config module at this moment.