Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing https://github.com/Ecwid/consul-api with Interface Clients #475

Open
spencergibb opened this issue Dec 11, 2018 · 11 comments

Comments

@spencergibb
Copy link
Member

A move to non-blocking infrastructure like spring-cloud-loadbalancer will be problematic with a blocking client.

@varnson
Copy link
Contributor

varnson commented Jun 16, 2019

Is anyone working on consul-api with WebClient?

@pturczyk
Copy link

pturczyk commented Jul 12, 2023

It seems that although Ecwid/consula-api is still listed on official consul API docs, it is not really actively maintained. Last release happened on Apr 9, 2020 and reported Issues are not being addressed nor commented.

Perhaps it's worth bringing up the topic of replacing the underlying Consul API again. Especially, as some API's has been deprecated and some new features like caching are not supported.

@spencergibb spencergibb changed the title Consider replacing https://github.com/Ecwid/consul-api with WebClient Consider replacing https://github.com/Ecwid/consul-api with Interface Clients Jul 12, 2023
@spencergibb
Copy link
Member Author

I would use the new Interface Clients from Spring Framework. It would make it easy to do both reactive and blocking.

@alex-kormukhin
Copy link

alex-kormukhin commented Feb 29, 2024

Consul token query parameter deprecated in Consul 1.17 #809

@M-Whitaker
Copy link

Is anyone working on this? Are you accepting PRs?

@spencergibb
Copy link
Member Author

Not yet, PRs wecome

@M-Whitaker
Copy link

I’m happy to start to look at creating an interface client as suggested removing the lib from the config module.

@M-Whitaker
Copy link

@spencergibb Any comments on the current draft PR are most welcome to get some feedback on the implementation.

@spencergibb
Copy link
Member Author

I will look when I have time

@monwolf
Copy link

monwolf commented Oct 7, 2024

@spencergibb it's still pending, are you planning to review this PR?

@spencergibb
Copy link
Member Author

@monwolf as the PR stands, it will need to wait for our major in 2025.1 (Nov 2025) as it is a breaking change. If you want to make it opt-in, I can schedule it for 2025.0 (May 2025) and then we can remove the old one in 2025.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants