Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port blog page. #2

Merged
merged 3 commits into from
Feb 17, 2017
Merged

Port blog page. #2

merged 3 commits into from
Feb 17, 2017

Conversation

maxlazio
Copy link

@maxlazio maxlazio commented Feb 9, 2017

Part of git#942 .

@spraints
Copy link
Owner

@maxlazio I noticed a couple of things, while comparing a local copy of this to git-scm.com.

The blog post urls look like http://127.0.0.1:4000/2010/03/04/smart-http.html instead of https://git-scm.com/blog/2010/03/04/smart-http.html. I think it's a pretty simple change to _config.yml to set the permalink for all of them?

Also, the styles for some of the <pre> (?) elements is off.
git-scm.com:

screen shot 2017-02-09 at 8 03 45 pm

this branch:

screen shot 2017-02-09 at 8 03 38 pm

I'm not in love with either style, tbh, but it'd be nice to match what's there or make it look a little better.

@peff
Copy link

peff commented Feb 10, 2017

I actually wonder if we should drop the blog posts entirely. They're quite old at this point, and my understanding is that the original purpose was to act as a sort of ongoing addendum to Pro Git. But since they were written, Pro Git 2 was published, which should have incorporated that content.

@ben @schacon Any thoughts on that?

@ben
Copy link

ben commented Feb 10, 2017

Yeah, we tried to grab the best content and integrate it into the 2nd edition of the book. The "three trees" post, for instance, became section 7.7.

I'm totally cool with dropping them for all the reasons @peff said, but @schacon's opinion probably matters more than mine here.

@maxlazio
Copy link
Author

@spraints I'll hold of from improvements until we get a decision about whether the page is even necessary.

@peff
Copy link

peff commented Feb 15, 2017

I'm not sure if we'll hear from @schacon or not. So I'll make an executive decision: let's drop the blog posts going forward. If there's good content in them that isn't covered elsewhere, I'd much rather see it rolled into the book or into Git's manpages.

I'm not sure if we should do something for people linking to them, so they don't just get a 404. Maybe just a page that says "hey, go read Pro Git" with a link to the book.

@maxlazio
Copy link
Author

Allright, blog can be skipped then :) I've left the main blog page in case someone ends up there from old links.

@spraints
Copy link
Owner

😎

@peff
Copy link

peff commented Feb 17, 2017

I've left the main blog page in case someone ends up there from old links.

That sounds good. We could also put redirects for all the old page names, but I'm happy for that to come later (or never) when somebody complains.

@spraints spraints merged commit a3f7d5d into spraints:gh-pages Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants