Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TypeScript and add types to ApiClient and vuex store #81

Merged
merged 3 commits into from
Feb 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{
"recommendations": [
"Vue.volar",
"vue.vscode-typescript-vue-plugin",
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"golang.go",
"ms-python.python",
"ms-python.black-formatter"
],
"unwantedRecommendations": [
"vscode.typescript-language-features",
]
}
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ You likely want to add some arguments to the `go run` command, check `-help`
## UI Development

- make sure you can run Pkappa2
- for development with vscode: disable `@builtin typescript` extension and let [Volar takeover](https://vuejs.org/guide/typescript/overview.html#volar-takeover-mode) for full typescript support in Vue files
- run `yarn serve` in `/web`
- run `go run cmd/pkappa2/main.go -address :8081` in `/`
- visit `localhost:8080` in your web browser
Expand Down
21 changes: 19 additions & 2 deletions web/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,39 @@ module.exports = {
root: true,
env: {
node: true,
"vue/setup-compiler-macros": true,
},
parserOptions: {
ecmaVersion: 2021,
parser: "@babel/eslint-parser",
project: "./tsconfig.json",
parser: "@typescript-eslint/parser",
},
ignorePatterns: ["**/*.js", "**/*.vue"],
plugins: ["@typescript-eslint", "@typescript-eslint/eslint-plugin"],
parser: "vue-eslint-parser",
extends: [
// add more generic rulesets here, such as:
"eslint:recommended",
// 'plugin:vue/vue3-recommended',
"plugin:vue/recommended", // Use this if you are using Vue.js 2.x.
"prettier",
"@vue/typescript",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended",
"plugin:vue/base",
],
rules: {
// override/add rules settings here, such as:
// 'vue/no-unused-vars': 'error'
"no-console": "off",
"no-debugger": process.env.NODE_ENV === "production" ? "warn" : "off",
// "@typescript-eslint/no-explicit-any": "off",
// "@typescript-eslint/no-inferrable-types": "off",
// "@typescript-eslint/no-non-null-assertion": "off",
// "vue/script-setup-uses-vars": "error",
// "vue/v-on-event-hyphenation": "off",
"vue/multi-word-component-names": "off",
"vue/no-reserved-component-names": "off",
// "vue/no-reserved-component-names": "off",
},
};
5 changes: 0 additions & 5 deletions web/jsconfig.json

This file was deleted.

6 changes: 6 additions & 0 deletions web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,22 @@
},
"devDependencies": {
"@babel/eslint-parser": "^7.19.1",
"@types/vue-moment": "^4.0.7",
"@typescript-eslint/eslint-plugin": "^5.4.0",
"@typescript-eslint/parser": "^5.4.0",
"@vue/cli": "^5.0.6",
"@vue/cli-plugin-babel": "^5.0.6",
"@vue/cli-plugin-eslint": "^5.0.6",
"@vue/cli-plugin-typescript": "~5.0.0",
"@vue/cli-service": "^5.0.6",
"@vue/eslint-config-typescript": "^12.0.0",
"eslint": "^8.27.0",
"eslint-config-prettier": "^8.6.0",
"eslint-plugin-vue": "^9.7.0",
"prettier": "^2.8.3",
"sass": "~1.32.0",
"sass-loader": "^13.1.0",
"typescript": "~4.5.5",
"vue-cli-plugin-vuetify": "^2.5.8",
"vuetify-loader": "^1.9.2"
},
Expand Down
104 changes: 0 additions & 104 deletions web/src/apiClient.js

This file was deleted.

Loading
Loading