Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Add --cpus options to a container #1034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabrielsvinha
Copy link
Contributor

@gabrielsvinha gabrielsvinha commented Jun 3, 2018

Changes the class HostConfig to receive the property cpus when creating a new container.

Add unit test to the specified parameters.

Solves #959

@codecov-io
Copy link

codecov-io commented Jun 3, 2018

Codecov Report

Merging #1034 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1034   +/-   ##
=========================================
  Coverage     67.39%   67.39%           
  Complexity      774      774           
=========================================
  Files           176      176           
  Lines          3233     3233           
  Branches        367      367           
=========================================
  Hits           2179     2179           
  Misses          897      897           
  Partials        157      157

Copy link
Contributor

@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Is the key "Cpus" though? The docs don't have a "Cpus", but there is a "NanoCPUs".

API version 1.26, 1.37

@davidxia
Copy link
Contributor

davidxia commented Sep 30, 2018

@gabrielsvinha just wondering about the above.

@rwmajor2
Copy link

Can someone comment on this? There is a CpuCount, but is it really Windows only? It's located under the HostConfig.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants