Migrate TSlint to ESLint

spotfiresoftware · Jan 30, 2021 · 5139d13 · 5139d13
1 parent 9248e1d
commit 5139d13
Show file tree

Hide file tree

Showing 28 changed files with 1,784 additions and 231 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,143 @@
+{
+  "root": true,
+  "ignorePatterns": [
+    "projects/**/*"
+  ],
+  "overrides": [
+    {
+      "files": [
+        "*.ts"
+      ],
+      "parserOptions": {
+        "project": [
+          "tsconfig.json"
+        ],
+        "createDefaultProgram": true
+      },
+      "extends": [
+        "plugin:@angular-eslint/ng-cli-compat",
+        "plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
+        "plugin:@angular-eslint/template/process-inline-templates"
+      ],
+      "rules": {
+        "@angular-eslint/component-selector": [
+          "off",
+          {
+            "type": "",
+            "prefix": "kebab-case"
+          }
+        ],
+        "@angular-eslint/directive-selector": [
+          "off",
+          {
+            "type": "",
+            "prefix": "camelCase"
+          }
+        ],
+        "@typescript-eslint/array-type": [
+          "error",
+          {
+            "default": "array"
+          }
+        ],
+        "@typescript-eslint/dot-notation": "off",
+        "@typescript-eslint/explicit-member-accessibility": [
+          "error",
+          {
+            "accessibility": "no-public"
+          }
+        ],
+        "@typescript-eslint/member-delimiter-style": [
+          "error",
+          {
+            "multiline": {
+              "delimiter": "semi",
+              "requireLast": true
+            },
+            "singleline": {
+              "delimiter": "semi",
+              "requireLast": true
+            }
+          }
+        ],
+        "@typescript-eslint/no-inferrable-types": "error",
+        "@typescript-eslint/semi": [
+          "error"
+        ],
+        "brace-style": [
+          "error",
+          "1tbs"
+        ],
+        "max-len": [
+          "error",
+          {
+            "code": 140,
+            "ignoreTemplateLiterals": true,
+            "ignoreRegExpLiterals": true
+          }
+        ],
+        "comma-dangle": "error",
+        "no-underscore-dangle": "off",
+        "no-duplicate-imports": "error",
+        "no-irregular-whitespace": "error",
+        "no-multiple-empty-lines": [
+          "error",
+          {
+            "max": 1
+          }
+        ],
+        "import/order": [
+          "error",
+          {
+            "groups": [
+              "external",
+              "builtin",
+              "parent",
+              "sibling",
+              "internal",
+              "index",
+              "object"
+            ],
+            "pathGroups": [
+              {
+                "pattern": "@angular/**",
+                "group": "external",
+                "position": "before"
+              },
+              {
+                "pattern": "app/**",
+                "group": "sibling",
+                "position": "before"
+              }
+            ],
+            "pathGroupsExcludedImportTypes": [
+              "builtin"
+            ],
+            "newlines-between": "always",
+            "alphabetize": {
+              "order": "asc",
+              "caseInsensitive": true
+            }
+          }
+        ],
+        "no-redeclare": "error",
+        "space-before-function-paren": [
+          "error",
+          {
+            "named": "never",
+            "anonymous": "always"
+          }
+        ]
+      }
+    },
+    {
+      "files": [
+        "*.html"
+      ],
+      "extends": [
+        "plugin:@angular-eslint/template/recommended"
+      ],
+      "rules": {}
+    }
+  ]
+}
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,7 +10,6 @@ Wrapper for TIBCO Spotfire(R) Changelog
  * Upgrade to Angular 11.1.1
 
 
-
 <a name="0.13.0"></a>
 ## [0.13.0] (2020-10-16)
 

diff --git a/angular.json b/angular.json
@@ -81,14 +81,11 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": [
-              "src/tsconfig.app.json",
-              "src/tsconfig.spec.json"
-            ],
-            "exclude": [
-              "**/node_modules/**"
+            "lintFilePatterns": [
+              "src/**/*.ts",
+              "src/**/*.html"
             ]
           }
         }
@@ -207,13 +204,13 @@
           "options": {
             "tsConfig": "projects/spotfire-wrapper/tsconfig.lib.json",
             "project": "projects/spotfire-wrapper/ng-package.json"
-          }
-        ,          "configurations": {
+          },
+          "configurations": {
             "production": {
               "tsConfig": "projects/spotfire-wrapper/tsconfig.lib.prod.json"
             }
           }
-},
+        },
         "test": {
           "builder": "@angular-devkit/build-angular:karma",
           "options": {
@@ -223,14 +220,11 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": [
-              "projects/spotfire-wrapper/tsconfig.lib.json",
-              "projects/spotfire-wrapper/tsconfig.spec.json"
-            ],
-            "exclude": [
-              "**/node_modules/**"
+            "lintFilePatterns": [
+              "projects/spotfire-wrapper/**/*.ts",
+              "projects/spotfire-wrapper/**/*.html"
             ]
           }
         }
@@ -244,4 +238,4 @@
       "style": "scss"
     }
   }
-}
+}
diff --git a/build.sh b/build.sh
@@ -19,6 +19,9 @@ cp -v projects/spotfire-wrapper/CHANGELOG.md CHANGELOG.md
 title "Install dependencies:"
 npm install
 
+title "Lint code:"
+ng lint
+
 title "[spotfire-wrapper] Build the NPM package:"
 ./node_modules/.bin/ng build spotfire-wrapper --prod
 (cd projects/spotfire-wrapper/ ; npm run build --prod )

diff --git a/demo1/tsconfig.app.json b/demo1/tsconfig.app.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.base.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "outDir": "../out-tsc/app",
     "types": []

diff --git a/demo2/tsconfig.app.json b/demo2/tsconfig.app.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.base.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "outDir": "../out-tsc/app",
     "types": []

diff --git a/demo3/tsconfig.app.json b/demo3/tsconfig.app.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.base.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "outDir": "../out-tsc/app",
     "types": []

diff --git a/dist/spotfire-wrapper.js b/dist/spotfire-wrapper.js
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,7 +10,6 @@ Wrapper for TIBCO Spotfire(R) Changelog
		* Upgrade to Angular 11.1.1



		<a name="0.13.0"></a>
		## [0.13.0] (2020-10-16)

Expand Down