Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a PR template with checklist to fulfill CII badge requirements #98

Merged
merged 2 commits into from
May 20, 2021

Conversation

egpbos
Copy link
Collaborator

@egpbos egpbos commented May 19, 2021

This PR can be used to remind ourselves of the sustainability/quality standards we set for ourselves following the CII checklist in #93.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #98 (ba9cb8d) into master (20d32bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   71.90%   71.90%           
=======================================
  Files          32       32           
  Lines        2157     2157           
=======================================
  Hits         1551     1551           
  Misses        606      606           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d32bb...ba9cb8d. Read the comment docs.

@egpbos egpbos requested review from bhigy and cwmeijer May 19, 2021 14:42
@egpbos
Copy link
Collaborator Author

egpbos commented May 19, 2021

I've gone through the CII checklist and don't think we need more items here (from CII at least), so ready to review/merge.

@egpbos egpbos merged commit 0fc9add into master May 20, 2021
@bhigy bhigy deleted the pr_template_cii_badge branch May 25, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants