Android support milestone2 #73
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
============================================
+ Coverage 87.35% 88.39% +1.04%
- Complexity 939 971 +32
============================================
Files 119 122 +3
Lines 3170 3394 +224
Branches 447 461 +14
============================================
+ Hits 2769 3000 +231
+ Misses 284 260 -24
- Partials 117 134 +17
Continue to review full report at Codecov.
|
|
Seems the timeout on websocket tests may need adjusted further for these github actions. |
|
@splix get a chance to look? |
|
@nschwermann hi, I've made couple of comments to the code, can you take a look? see above |
|
Hey @splix I am not seeing any comments? |
| JavaType type = objectMapper.getTypeFactory().constructParametricType(RpcResponse.class, clazz); | ||
| RpcResponse<T> response; | ||
| try { | ||
| response = objectMapper.readerFor(type).readValue(content); | ||
| if(content instanceof String) response = objectMapper.readerFor(type).readValue((String)content); |
There was a problem hiding this comment.
I'm not sure that instanceof is a good idea here. Maybe you can use InputStream as a default type, and wrap String to an InputStream in decode(int id, String content, JavaType clazz). That should be more effective and less error prone.
| SecureRandom secureRandom; | ||
| try{ | ||
| try{ | ||
| SecureRandom.class.getMethod("getInstanceStrong"); |
|
Oh, apparently I didn't click "Request Changes" button and it turns out without it you don't see the comments though I've made them like a month ago. Sorry about that |
|
LOL @splix no worries man I saw when I submit you were on vacation so I didn't poke you! I was thinking I need to start vacationing like you do! |
|
Feedback looks good, good catches I will get those resolved asap wrapping up another project atm. |
|
Hi @nschwermann. Just wondering if you're still working on it. Or maybe someone else could quickly fix those things and I can merge it. |
Milestone 2 of Android Support
w3f/Grants-Program#573
Resolves:
#42
#45
#47
#59
#70