-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce enable/disable experiment cohorting #615
Conversation
Thanks for the Pull Request @robin-phung ✨ I wanna do some testing just to make sure it's all good before merging. The |
@andrehjr Let me know what your thoughts are on refactoring as I'm also interested (and may be able to assist/collab) in a refactor of the Helper#ab_test ~> Trial#choose!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes and we should be good to merge. 🚀 Sorry for taking so long.
Being able to 'soft close' an experiment does look useful to give more control over experiments.
Sure! Help is always welcome. I've started the other day a few spikes starting with the ab_test method in #623 in order to start preparing things. |
Updated PR with the following changes:
|
@robin-phung can you rebase these changes? 18c0514 is already on master 648576a And that's it! 🚀 |
f06b16b
to
f9fc878
Compare
My rebase went out of whack, it should be resolved now. |
What problem does this solve?
Disabling Cohorting: Allow existing registered participants time to convert while no longer accepting new participants into the experiment. New participants will be given the control will be given the control and will not be recorded as being apart of the experiment.
Why is this useful?
How does this solve it?