We can just check if request/params are there

splitrb · Mar 3, 2024 · 971673b · 971673b
1 parent f71cb5b
commit 971673b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/split/encapsulated_helper.rb b/lib/split/encapsulated_helper.rb
@@ -24,7 +24,7 @@ def initialize(context)
       end
 
       def params
-        request.params if request_present?
+        request.params if request && request.respond_to?(:params)
       end
 
       def request

diff --git a/lib/split/helper.rb b/lib/split/helper.rb
@@ -163,11 +163,11 @@ def is_ignored_ip_address?
     end
 
     def params_present?
-      defined?(params) && params != nil
+      defined?(params) && params
     end
 
     def request_present?
-      defined?(request) && request != nil
+      defined?(request) && request
     end
 
     def active_experiments