moved sanitization for flagsets before setting the config

splitio/commitsha.go

@@ -1,3 +1,3 @@
 package splitio
 
-const CommitSHA = "0d2ade1"
+const CommitSHA = "67fb0db"

splitio/sdk/conf/conf.go

@@ -4,6 +4,8 @@ import (
 	"time"
 
 	"github.com/splitio/go-split-commons/v5/conf"
+	"github.com/splitio/go-split-commons/v5/dtos"
+	"github.com/splitio/go-split-commons/v5/flagsets"
 )
 
 const (
@@ -125,5 +127,16 @@ func (c *Config) Normalize() []string {
 		c.Impressions.SyncPeriod = minimumImpressionsRefreshRate
 	}
 
+	// Sanitize flagsets and append erros into warnings for logging purposes
+	sanitizedFlagSets, warns := flagsets.SanitizeMany(c.FlagSetsFilter)
+	if len(warns) != 0 {
+		for _, err := range warns {
+			if errType, ok := err.(dtos.FlagSetValidatonError); ok {
+				warnings = append(warnings, errType.Message)
+			}
+		}
+	}
+	c.FlagSetsFilter = sanitizedFlagSets
+
 	return warnings
 }

splitio/sdk/sdk.go

@@ -72,15 +72,7 @@ func New(logger logging.LoggerInterface, apikey string, c *conf.Config) (*Impl,
 	md := dtos.Metadata{SDKVersion: fmt.Sprintf("splitd-%s", splitio.Version)}
 	advCfg := c.ToAdvancedConfig()
 
-	flagSets, errs := flagsets.SanitizeMany(advCfg.FlagSetsFilter)
-	if len(errs) != 0 {
-		for _, err := range errs {
-			if errType, ok := err.(dtos.FlagSetValidatonError); ok {
-				logger.Warning(errType.Message)
-			}
-		}
-	}
-	flagSetsFilter := flagsets.NewFlagSetFilter(flagSets)
+	flagSetsFilter := flagsets.NewFlagSetFilter(advCfg.FlagSetsFilter)
 
 	stores := setupStorages(c, flagSetsFilter)
 	impc, err := setupImpressionsComponents(&c.Impressions, stores.telemetry)