added input validation

cmd/splitd/main.go

@@ -24,6 +24,7 @@ func main() {
 		fmt.Println("error reading config: ", err.Error())
 		os.Exit(1)
 	}
+	fmt.Println("cfg.SDK.FlagSetsFilter", cfg.SDK.FlagSetsFilter)
 	handleFlags(cfg)
 
 	loggerCfg, err := cfg.Logger.ToLoggerOptions()

splitio/commitsha.go

@@ -1,3 +1,3 @@
 package splitio
 
-const CommitSHA = "b98165e"
+const CommitSHA = "80fae64"

splitio/conf/splitd.go

@@ -127,7 +127,8 @@ type SDK struct {
 	URLs             URLs         `yaml:"urls"`
 	FeatureFlags     FeatureFlags `yaml:"featureFlags"`
 	Impressions      Impressions  `yaml:"impressions"`
-	Events           Events       `yank:"events"`
+	Events           Events       `yaml:"events"`
+	FlagSetsFilter   []string     `yaml:"flagSetsFilter"`
 }
 
 func (s *SDK) PopulateWithDefaults() {
@@ -139,6 +140,7 @@ func (s *SDK) PopulateWithDefaults() {
 	s.FeatureFlags.PopulateWithDefaults()
 	s.Impressions.PopulateWithDefaults()
 	s.Events.PopulateWithDefaults()
+	s.FlagSetsFilter = []string{}
 }
 
 type FeatureFlags struct {
@@ -209,6 +211,8 @@ func (s *SDK) ToSDKConf() *sdkConf.Config {
 	lang.SetIfNotEmpty(&cfg.Events.QueueSize, s.Events.QueueSize)
 	lang.MapIfNotNil(&cfg.Events.SyncPeriod, s.Events.RefreshRateSeconds, durationFromSeconds)
 	s.URLs.updateSDKConfURLs(&cfg.URLs)
+	// lang.SetIfNotNil(&cfg.FlagSetsFilter, s.FlagSetsFilter)
+	fmt.Println("TOSDKCONFIG", s.FlagSetsFilter)
 	return cfg
 }
 

splitio/sdk/conf/conf.go

@@ -114,6 +114,7 @@ func DefaultConfig() *Config {
 			Streaming: "https://streaming.split.io/sse",
 			Telemetry: "https://telemetry.split.io/api/v1",
 		},
+		FlagSetsFilter: []string{},
 	}
 }
 

splitio/sdk/conf/conf_test.go

@@ -32,4 +32,5 @@ func TestSDKConf(t *testing.T) {
 	assert.Equal(t, int64(dc.Segments.UpdateBufferSize), adv.SegmentUpdateQueueSize)
 	assert.Equal(t, int(dc.Splits.SyncPeriod.Seconds()), adv.SplitsRefreshRate)
 	assert.Equal(t, int(dc.Segments.SyncPeriod.Seconds()), adv.SegmentsRefreshRate)
+	assert.Equal(t, dc.FlagSetsFilter, adv.FlagSetsFilter)
 }

splitio/sdk/sdk.go

@@ -72,7 +72,15 @@ func New(logger logging.LoggerInterface, apikey string, c *conf.Config) (*Impl,
 	md := dtos.Metadata{SDKVersion: fmt.Sprintf("splitd-%s", splitio.Version)}
 	advCfg := c.ToAdvancedConfig()
 
-	flagSetsFilter := flagsets.NewFlagSetFilter(advCfg.FlagSetsFilter)
+	flagSets, errs := flagsets.SanitizeMany(advCfg.FlagSetsFilter)
+	if len(errs) != 0 {
+		for _, err := range errs {
+			if errType, ok := err.(dtos.FlagSetValidatonError); ok {
+				logger.Warning(errType.Message)
+			}
+		}
+	}
+	flagSetsFilter := flagsets.NewFlagSetFilter(flagSets)
 
 	stores := setupStorages(c, flagSetsFilter)
 	impc, err := setupImpressionsComponents(&c.Impressions, stores.telemetry)