Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving log attempts #252

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Moving log attempts #252

merged 1 commit into from
Nov 15, 2023

Conversation

ldecheverz-split
Copy link
Contributor

Split Synchronizer

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@ldecheverz-split ldecheverz-split requested a review from a team as a code owner November 15, 2023 17:54
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition B Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

nmayorsplit
nmayorsplit approved these changes Nov 15, 2023
View reviewed changes
Copy link

@nmayorsplit nmayorsplit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldecheverz-split ldecheverz-split merged commit b6b17e0 into project/flagsets Nov 15, 2023
5 of 6 checks passed
@ldecheverz-split ldecheverz-split deleted the move-log-attempts branch November 15, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmayorsplit nmayorsplit nmayorsplit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldecheverz-split @nmayorsplit