fixing build

splitio · Jan 8, 2024 · 8b2aefc · 8b2aefc
1 parent 8b21e4e
commit 8b2aefc
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 18 deletions.
diff --git a/splitio/proxy/caching/workers_test.go b/splitio/proxy/caching/workers_test.go
@@ -289,6 +289,9 @@ func (*splitStorageMock) FetchMany(splitNames []string) map[string]*dtos.SplitDT
 func (*splitStorageMock) GetNamesByFlagSets(sets []string) map[string][]string {
 	panic("unimplemented")
 }
+func (*splitStorageMock) GetAllFlagSetNames() []string {
+	panic("unimplemented")
+}
 func (*splitStorageMock) KillLocally(splitName string, defaultTreatment string, changeNumber int64) {
 	panic("unimplemented")
 }
@@ -346,28 +349,28 @@ func (*segmentStorageMock) SegmentContainsKey(segmentName string, key string) (b
 func (*segmentStorageMock) SegmentKeysCount() int64 { panic("unimplemented") }
 
 /*
-type segmentUpdaterMock struct {
-	SynchronizeSegmentCall  func(name string, till *int64) (*segment.UpdateResult, error)
-	SynchronizeSegmentsCall func() (map[string]segment.UpdateResult, error)
-	SegmentNamesCall        func() []interface{}
-	IsSegmentCachedCall     func(segmentName string) bool
-}
+	type segmentUpdaterMock struct {
+		SynchronizeSegmentCall  func(name string, till *int64) (*segment.UpdateResult, error)
+		SynchronizeSegmentsCall func() (map[string]segment.UpdateResult, error)
+		SegmentNamesCall        func() []interface{}
+		IsSegmentCachedCall     func(segmentName string) bool
+	}
 
-func (s *segmentUpdaterMock) SynchronizeSegment(name string, till *int64) (*segment.UpdateResult, error) {
-	return s.SynchronizeSegmentCall(name, till)
-}
+	func (s *segmentUpdaterMock) SynchronizeSegment(name string, till *int64) (*segment.UpdateResult, error) {
+		return s.SynchronizeSegmentCall(name, till)
+	}
 
-func (s *segmentUpdaterMock) SynchronizeSegments() (map[string]segment.UpdateResult, error) {
-	return s.SynchronizeSegmentsCall()
-}
+	func (s *segmentUpdaterMock) SynchronizeSegments() (map[string]segment.UpdateResult, error) {
+		return s.SynchronizeSegmentsCall()
+	}
 
-func (s *segmentUpdaterMock) SegmentNames() []interface{} {
-	return s.SegmentNamesCall()
-}
+	func (s *segmentUpdaterMock) SegmentNames() []interface{} {
+		return s.SegmentNamesCall()
+	}
 
-func (s *segmentUpdaterMock) IsSegmentCached(segmentName string) bool {
-	return s.IsSegmentCachedCall(segmentName)
-}
+	func (s *segmentUpdaterMock) IsSegmentCached(segmentName string) bool {
+		return s.IsSegmentCachedCall(segmentName)
+	}
 */
 var _ split.Updater = (*splitUpdaterMock)(nil)
 var _ storage.SplitStorage = (*splitStorageMock)(nil)

diff --git a/splitio/proxy/storage/splits.go b/splitio/proxy/storage/splits.go
@@ -179,6 +179,13 @@ func (*ProxySplitStorageImpl) GetNamesByFlagSets(sets []string) map[string][]str
 	return nil
 }
 
+// GetAllFlagSetNames implements storage.SplitStorage
+func (*ProxySplitStorageImpl) GetAllFlagSetNames() []string {
+	// NOTE: This method is NOT used by the proxy.
+	// we need to revisit our interfaces so that we're not obliged to do this smeely empty impls.
+	panic("unimplemented")
+}
+
 func (p *ProxySplitStorageImpl) setStartingPoint(cn int64) {
 	p.mtx.Lock()
 	// will be executed only the first time this method is called or when