Merge branch 'release-5.6.0' into SDKS-7838-cached-flag-sets

splitio · Jan 11, 2024 · 7135c5d · 7135c5d
2 parents ff7abe7 + 5e0177b
commit 7135c5d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/LICENSE b/LICENSE
@@ -1,4 +1,4 @@
-Copyright © 2023 Split Software, Inc.
+Copyright © 2024 Split Software, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

diff --git a/splitio/proxy/caching/workers_test.go b/splitio/proxy/caching/workers_test.go
@@ -289,6 +289,9 @@ func (*splitStorageMock) FetchMany(splitNames []string) map[string]*dtos.SplitDT
 func (*splitStorageMock) GetNamesByFlagSets(sets []string) map[string][]string {
 	panic("unimplemented")
 }
+func (*splitStorageMock) GetAllFlagSetNames() []string {
+	panic("unimplemented")
+}
 func (*splitStorageMock) KillLocally(splitName string, defaultTreatment string, changeNumber int64) {
 	panic("unimplemented")
 }

diff --git a/splitio/proxy/storage/splits.go b/splitio/proxy/storage/splits.go
@@ -182,6 +182,7 @@ func (*ProxySplitStorageImpl) GetNamesByFlagSets(sets []string) map[string][]str
 // GetAllFlagSetNames implements storage.SplitStorage
 func (*ProxySplitStorageImpl) GetAllFlagSetNames() []string {
 	// NOTE: This method is NOT used by the proxy.
+  // we need to revisit our interfaces so that we're not obliged to do this smeely empty impls.
 	return nil
 }