Skip to content

Commit

Permalink
Merge pull request #235 from splitio/multi_plat
Browse files Browse the repository at this point in the history
accept platform arg
  • Loading branch information
mmelograno authored Jun 21, 2023
2 parents 3ba3b9c + d7c3227 commit 6b4b6e5
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ PYTHON ?= python3
DOCKER ?= docker
BUILD ?= build
SHELL = /usr/bin/env bash -o pipefail
PLATFORM ?=

# Extra arguments
EXTRA_BUILD_ARGS ?=
Expand Down Expand Up @@ -87,8 +88,8 @@ entrypoints: entrypoint.synchronizer.sh entrypoint.proxy.sh

## Build release-ready docker images with proper tags and output push commands in stdout
images_release: # entrypoints
$(DOCKER) build -t splitsoftware/split-synchronizer:latest -t splitsoftware/split-synchronizer:$(version) -f docker/Dockerfile.synchronizer .
$(DOCKER) build -t splitsoftware/split-proxy:latest -t splitsoftware/split-proxy:$(version) -f docker/Dockerfile.proxy .
$(DOCKER) build $(platform_str) -t splitsoftware/split-synchronizer:latest -t splitsoftware/split-synchronizer:$(version) -f docker/Dockerfile.synchronizer .
$(DOCKER) build $(platform_str) -t splitsoftware/split-proxy:latest -t splitsoftware/split-proxy:$(version) -f docker/Dockerfile.proxy .
@echo "Images created. Make sure everything works ok, and then run the following commands to push them."
@echo "$(DOCKER) push splitsoftware/split-synchronizer:$(version)"
@echo "$(DOCKER) push splitsoftware/split-synchronizer:latest"
Expand Down Expand Up @@ -195,6 +196,7 @@ make_exec = $(if $(findstring windows,$1),$1.exe,$1)
installed_from_zip = $(if $(findstring split_sync,$1),split-sync,split-proxy)
apptitle_from_zip = $(if $(findstring split_sync,$1),Synchronizer,Proxy)
cmdfolder_from_bin = $(if $(findstring split_sync,$1),synchronizer,proxy)
platform_str = $(if $(PLATFORM),--platform=$(PLATFORM),)

# "constants"
null :=
Expand Down

0 comments on commit 6b4b6e5

Please sign in to comment.