polishing

splitio · Oct 25, 2024 · 5ca3be8 · 5ca3be8
1 parent 161461a
commit 5ca3be8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/splitio/proxy/service/api/large_segment_http_fetcher.go b/splitio/proxy/service/api/large_segment_http_fetcher.go
@@ -16,7 +16,7 @@ import (
 	"github.com/splitio/split-synchronizer/v5/splitio/proxy/service/dtos"
 )
 
-var MEM_VERSION_10 = "1.0"
+var MEM_VERSION_10 = "1.0" // support for csv format with one column
 
 const (
 	// Unknown format

diff --git a/splitio/proxy/service/api/large_segment_http_fetcher_test.go b/splitio/proxy/service/api/large_segment_http_fetcher_test.go
@@ -46,8 +46,7 @@ func TestFetchCsvMultipleColumns(t *testing.T) {
 		"api-key",
 		"1.0",
 		cmnConf.AdvancedConfig{
-			EventsURL: ts.URL,
-			SdkURL:    ts.URL,
+			SdkURL: ts.URL,
 		},
 		logger,
 		cmnDTOs.Metadata{},
@@ -88,8 +87,7 @@ func TestFetchCsvFormat(t *testing.T) {
 		"api-key",
 		"1.0",
 		cmnConf.AdvancedConfig{
-			EventsURL: ts.URL,
-			SdkURL:    ts.URL,
+			SdkURL: ts.URL,
 		},
 		logger,
 		cmnDTOs.Metadata{},
@@ -134,8 +132,7 @@ func TestFetchCsvFormatWithOtherVersion(t *testing.T) {
 		"api-key",
 		"1.0",
 		cmnConf.AdvancedConfig{
-			EventsURL: ts.URL,
-			SdkURL:    ts.URL,
+			SdkURL: ts.URL,
 		},
 		logger,
 		cmnDTOs.Metadata{},
@@ -177,8 +174,7 @@ func TestFetchUnknownFormat(t *testing.T) {
 		"api-key",
 		"1.0",
 		cmnConf.AdvancedConfig{
-			EventsURL: ts.URL,
-			SdkURL:    ts.URL,
+			SdkURL: ts.URL,
 		},
 		logger,
 		cmnDTOs.Metadata{},
@@ -202,8 +198,7 @@ func TestFetchAPIError(t *testing.T) {
 		"api-key",
 		"1.0",
 		cmnConf.AdvancedConfig{
-			EventsURL: ts.URL,
-			SdkURL:    ts.URL,
+			SdkURL: ts.URL,
 		},
 		logger,
 		cmnDTOs.Metadata{},
@@ -243,8 +238,7 @@ func TestFetchDownloadServerError(t *testing.T) {
 		"api-key",
 		"1.0",
 		cmnConf.AdvancedConfig{
-			EventsURL: ts.URL,
-			SdkURL:    ts.URL,
+			SdkURL: ts.URL,
 		},
 		logger,
 		cmnDTOs.Metadata{},