Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated React default imports to the recommended namespace imports #225

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Updated React default imports to the recommended namespace imports #225

wants to merge 3 commits into from

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Dec 5, 2024 •
edited
Loading

React SDK

What did you accomplish?

Updated React default imports to namespace imports as this is the recommended approach for improved compatibility:

  • Doesn't require esModuleInterop: true in TypeScript configurations.
  • Some build/bundle tools and configurations may handle ES namespace imports more predictably for tree-shaking.

How do we test the changes introduced in this PR?

Validated in projects with different configurations:

  • Default TypeScript config (esModuleInterop: false)
  • Using the latest React SDK version.
  • Using the minimum React SDK version required by the SDK.

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner December 5, 2024 18:27
@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EmilianoSanchez