[Breaking change] factory, client, and track method available in initial render when using config prop.
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when a config prop is provided
[Breaking change] Remove deprecated modules
[Breaking change] Rename `SplitSdk` function to `SplitFactory`
[Breaking change] Drop support for React <16.8.0
[Breaking change] Error handling updates
…able_in_initial_render
sanzmauro
approved these changes
Oct 28, 2024
Polishing: upgrade JS SDK, add TSDoc linter
EmilianoSanchez
deleted the
issue_198_factory_available_in_initial_render
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React SDK
What did you accomplish?
When the
configprop is provided, theSplitFactoryProvidernow makes the SDK factory and client instances available in the context immediately during the initial render, instead of waiting for the first SDK event. This change:useTrackhook, which was retrieving a no-op function instead of the client'strackmethod during the initial render.configprop.Updated the
useTrackhook to retrieve the clienttrackreference rather than a bound version of it, as there is no need to bind the function. By retrieving the same reference per client, it can be used as a reactive dependency inuseEffect, which only changes if the underlying client changes.How do we test the changes introduced in this PR?
Extra Notes
Related to #198 and #192