Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks evaluation optimization #154

Merged
merged 10 commits into from
Nov 2, 2023
Merged

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Jul 17, 2023

React SDK

What did you accomplish?

  • Like SplitTreatments, both useSplitTreatments and useTreatments use a memoized version of client.getTreatmentsWithConfig to avoid duplicated impressions and unnecessary re-renders.

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner July 17, 2023 20:47
@EmilianoSanchez EmilianoSanchez changed the title Hooks polishing [WIP] Hooks polishing Jul 22, 2023
@EmilianoSanchez EmilianoSanchez changed the title Hooks polishing Hooks evaluation optimization Sep 14, 2023
Base automatically changed from hooks_update_options to hooks_baseline September 19, 2023 14:25
@EmilianoSanchez EmilianoSanchez merged commit 6e94a5b into hooks_baseline Nov 2, 2023
3 checks passed
@EmilianoSanchez EmilianoSanchez deleted the hooks_polishing branch November 2, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants