Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: rename and reuse some utility functions #282

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

EmilianoSanchez
Copy link
Contributor

Javascript commons library

What did you accomplish?

  • mode -> validateMode
  • isStorageSync -> isConsumerMode

How do we test the changes introduced in this PR?

Extra Notes

… 'mode' to 'validateMode' function for consistency with other validation utilities
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner December 6, 2023 14:03
@EmilianoSanchez EmilianoSanchez merged commit cf2d026 into development Dec 6, 2023
2 checks passed
@EmilianoSanchez EmilianoSanchez deleted the reuse_isConsumerMode_util branch December 6, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants