Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDKS-7794] Add flag sets support in Redis storage #274

Merged
merged 7 commits into from
Nov 29, 2023
Merged

[SDKS-7794] Add flag sets support in Redis storage #274

merged 7 commits into from
Nov 29, 2023

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Nov 27, 2023 •
edited
Loading

Javascript commons library

What did you accomplish?

  • Implement SplitsCacheInRedis::getNamesByFlagSets method for consumer modes
  • Update SplitsCacheInRedis::addSplit and SplitsCacheInRedis::removeSplit methods to update flag sets for producer mode
  • Log errors from Redis commands.

How do we test the changes introduced in this PR?

  • Unit tests

Extra Notes

Base automatically changed from flagsets_no_feature_flags_warning to flagsets_baseline November 28, 2023 15:48
@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review November 29, 2023 15:09
@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 29, 2023 15:09
nmayorsplit
nmayorsplit approved these changes Nov 29, 2023
View reviewed changes
Copy link

@nmayorsplit nmayorsplit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmilianoSanchez EmilianoSanchez merged commit 2476efc into flagsets_baseline Nov 29, 2023
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the SDKS-7794-flagsets_in_redis_storage branch November 29, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmayorsplit nmayorsplit nmayorsplit approved these changes

@emmaz90 emmaz90 emmaz90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilianoSanchez @emmaz90 @nmayorsplit