Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDKS-7795] Validation of feature flag filters in consumer and partial consumer modes #271

Merged

Conversation

EmilianoSanchez
Copy link
Contributor

Javascript commons library

What did you accomplish?

Log a warning and ignore feature flag filters if they are provided in consumer and partial consumer modes

How do we test the changes introduced in this PR?

Unit tests

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 23, 2023 19:43
Copy link

@nmayorsplit nmayorsplit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmilianoSanchez EmilianoSanchez merged commit d8b88f5 into flagsets_baseline Nov 24, 2023
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the SDKS-7795-flagsets_consumer_mode_validation branch November 24, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants