Update logic & error log when using sets with other filters #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
IMO it is okey the change in the error message.
Approved, but just check with the team if the change in the matchFilters is Okay, because we mention here https://github.com/splitio/javascript-client/blob/development/types/splitio.d.ts#L226 that the "by prefix" filter is not being supported. If the change is OK, we should update eventually the comment at https://github.com/splitio/javascript-client/blob/development/types/splitio.d.ts#L226 and the equivalent lines in JS Browser and React Native SDKs.
EmilianoSanchez
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript commons library
What did you accomplish?
matchFiltersmethodHow do we test the changes introduced in this PR?
unit tests included
Extra Notes