Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.9.1 #251

Merged
merged 5 commits into from
Sep 21, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update linter dependencies to fix vulnerabilities. Fix eslint-plugin-…
…compat configuration.
EmilianoSanchez committed Sep 7, 2023
commit e7330a2f2dde6a0c630d60249f6a60e9383a4fa0
4 changes: 2 additions & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -73,14 +73,14 @@
},
{
"selector": "ForInStatement",
"message": "Don't use for-in syntax in libraries, because it iterates over members inherited from the prototype chain"
"message": "Don't use for-in syntax in libraries, because it iterates over properties in the prototype chain that can be polluted by other libraries"
},
{
"selector": "TSEnumDeclaration[const=true]",
"message": "Don't declare const enum, because it is not supported by Babel used for building RN SDK"
}
],
"compat/compat": ["error", "defaults, not ie < 10, not node < 6"],
"compat/compat": ["error", "defaults, ie 10, node 6"],
"no-throw-literal": "error",
"import/no-default-export": "error",
"import/no-self-import": "error"
2,132 changes: 1,050 additions & 1,082 deletions package-lock.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -60,12 +60,12 @@
"@types/ioredis": "^4.28.0",
"@types/jest": "^27.0.0",
"@types/lodash": "^4.14.162",
"@typescript-eslint/eslint-plugin": "^4.2.0",
"@typescript-eslint/parser": "^4.2.0",
"@typescript-eslint/eslint-plugin": "^6.6.0",
"@typescript-eslint/parser": "^6.6.0",
"cross-env": "^7.0.2",
"csv-streamify": "^4.0.0",
"eslint": "^7.32.0",
"eslint-plugin-compat": "3.7.0",
"eslint": "^8.48.0",
"eslint-plugin-compat": "^4.2.0",
"eslint-plugin-import": "^2.25.3",
"fetch-mock": "^9.11.0",
"ioredis": "^4.28.0",
2 changes: 1 addition & 1 deletion src/integrations/ga/GaToSplit.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable no-undef */
import { objectAssign } from '../../utils/lang/objectAssign';
import { isString, isFiniteNumber, uniqAsStrings } from '../../utils/lang';
import {
@@ -295,5 +294,6 @@ export function GaToSplit(sdkOptions: GoogleAnalyticsToSplitOptions, params: IIn
}

// Register the plugin, even if config is invalid, since, if not provided, it will block `ga` command queue.
// eslint-disable-next-line no-undef
providePlugin(window, 'splitTracker', SplitTracker, log, sdkOptions.autoRequire === true, telemetryTracker);
}
2 changes: 1 addition & 1 deletion src/storages/inMemory/TelemetryCacheInMemory.ts
Original file line number Diff line number Diff line change
@@ -181,7 +181,7 @@ export class TelemetryCacheInMemory implements ITelemetryCacheSync {
this.e = false;
}

private streamingEvents: StreamingEvent[] = []
private streamingEvents: StreamingEvent[] = [];

popStreamingEvents() {
return this.streamingEvents.splice(0);
2 changes: 1 addition & 1 deletion src/storages/inRedis/RedisAdapter.ts
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ interface IRedisCommand {
* Redis adapter on top of the library of choice (written with ioredis) for some extra control.
*/
export class RedisAdapter extends ioredis {
private readonly log: ILogger
private readonly log: ILogger;
private _options: object;
private _notReadyCommandsQueue?: IRedisCommand[];
private _runningCommands: ISet<Promise<any>>;
1 change: 1 addition & 0 deletions src/sync/streaming/parseUtils.ts
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@ function Uint8ArrayToString(myUint8Arr: Uint8Array) { // @ts-ignore

function StringToUint8Array(myString: string) {
const charCodes = myString.split('').map((e) => e.charCodeAt(0));
// eslint-disable-next-line compat/compat
return new Uint8Array(charCodes);
}

2 changes: 1 addition & 1 deletion src/utils/redis/RedisMock.ts
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ const PIPELINE_METHODS = ['rpush', 'hincrby'];

export class RedisMock {

private pipelineMethods: any = { exec: jest.fn(asyncFunction) }
private pipelineMethods: any = { exec: jest.fn(asyncFunction) };

constructor() {
IDENTITY_METHODS.forEach(method => {