Fix flagsets typo in storage #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
requested changes
Sep 22, 2023
| @@ -17,6 +18,7 @@ export abstract class AbstractSplitsCacheAsync implements ISplitsCacheAsync { | |||
| abstract getChangeNumber(): Promise<number> | |||
| abstract getAll(): Promise<ISplit[]> | |||
| abstract getSplitNames(): Promise<string[]> | |||
| abstract getNamesByFlagSets(flagsets: string[]): Promise<ISet<string>> | |||
There was a problem hiding this comment.
Emma, replace also the occurrences of flagsets to flagSets. Include others like flagsetsFilter to flagSetsFilter, etc.
| @@ -77,6 +78,11 @@ export abstract class AbstractSplitsCacheSync implements ISplitsCacheSync { | |||
| } | |||
| return false; | |||
| } | |||
| /** NO-OP */ | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| getNamesByFlagSets(flagsets: string[]): ISet<string> { | |||
There was a problem hiding this comment.
Why this is not abstract?
EmilianoSanchez
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript commons library
What did you accomplish?
FlagsetwithFlagSetgetNamesByFlagSetsmethod for in redis & pluggable storageHow do we test the changes introduced in this PR?
Extra Notes