Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include default treatment in SplitView #232

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Include default treatment in SplitView #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a322fd
add defaultValue to SplitView returned by manager; update types
nthorn552 Jul 13, 2023
a7f8cc3
update sdkManager test to expect newly added defaultValue in output
nthorn552 Jul 13, 2023
0bd7a5a
Merge branch 'development' into include-default-treatment-in-split-view
nthorn552 Jul 13, 2023
98654fe
Merge branch 'development' into include-default-treatment-in-split-view
nthorn552 Jul 26, 2023
f13bf46
Merge branch 'development' into include-default-treatment-in-split-view
NicoZelaya Sep 13, 2023
3171374
Merge branch 'development' into include-default-treatment-in-split-view
EmilianoSanchez Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sdkManager/__tests__/mocks/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
"treatments": ["on", "off"],
"configs": {
"on": "\"color\": \"green\""
}
},
"defaultTreatment": "off"
}
3 changes: 2 additions & 1 deletion src/sdkManager/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ function objectToView(splitObject: ISplit | null): SplitIO.SplitView | null {
killed: splitObject.killed,
changeNumber: splitObject.changeNumber || 0,
treatments: collectTreatments(splitObject),
configs: splitObject.configurations || {}
configs: splitObject.configurations || {},
defaultTreatment: splitObject.defaultTreatment
};
}

Expand Down
5 changes: 5 additions & 0 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,11 @@ export namespace SplitIO {
configs: {
[treatmentName: string]: string
}
/**
* Default treatment value for feature flag.
* @property {string} defaultTreatment
*/
defaultTreatment: string,
};
/**
* A promise that resolves to a feature flag view.
Expand Down
Loading