Add 'track' property in ImpressionDTO and 'trackImpressions' property…

… in ISplit
splitio · Dec 6, 2024 · e6d46fd · e6d46fd
1 parent 5014820
commit e6d46fd
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/src/dtos/types.ts b/src/dtos/types.ts
@@ -208,7 +208,8 @@ export interface ISplit {
   configurations?: {
     [treatmentName: string]: string
   },
-  sets?: string[]
+  sets?: string[],
+  trackImpressions?: boolean
 }
 
 // Split definition used in offline mode

diff --git a/src/evaluator/index.ts b/src/evaluator/index.ts
@@ -156,12 +156,14 @@ function getEvaluation(
       return evaluation.then(result => {
         result.changeNumber = split.getChangeNumber();
         result.config = splitJSON.configurations && splitJSON.configurations[result.treatment] || null;
+        result.track = splitJSON.trackImpressions;
 
         return result;
       });
     } else {
       evaluation.changeNumber = split.getChangeNumber(); // Always sync and optional
       evaluation.config = splitJSON.configurations && splitJSON.configurations[evaluation.treatment] || null;
+      evaluation.track = splitJSON.trackImpressions;
     }
   }
 

diff --git a/src/evaluator/types.ts b/src/evaluator/types.ts
@@ -25,7 +25,7 @@ export interface IEvaluation {
   config?: string | null
 }
 
-export type IEvaluationResult = IEvaluation & { treatment: string }
+export type IEvaluationResult = IEvaluation & { treatment: string; track?: boolean }
 
 export type ISplitEvaluator = (log: ILogger, key: SplitIO.SplitKey, splitName: string, attributes: SplitIO.Attributes | undefined, storage: IStorageSync | IStorageAsync) => MaybeThenable<IEvaluation>
 

diff --git a/src/sdkClient/client.ts b/src/sdkClient/client.ts
@@ -133,7 +133,7 @@ export function clientFactory(params: ISdkFactoryContext): SplitIO.IClient | Spl
     const matchingKey = getMatching(key);
     const bucketingKey = getBucketing(key);
 
-    const { treatment, label, changeNumber, config = null } = evaluation;
+    const { treatment, label, changeNumber, config = null, track } = evaluation;
     log.info(IMPRESSION, [featureFlagName, matchingKey, treatment, label]);
 
     if (validateSplitExistence(log, readinessManager, featureFlagName, label, invokingMethodName)) {
@@ -145,7 +145,8 @@ export function clientFactory(params: ISdkFactoryContext): SplitIO.IClient | Spl
         time: Date.now(),
         bucketingKey,
         label,
-        changeNumber: changeNumber as number
+        changeNumber: changeNumber as number,
+        track
       });
     }
 

diff --git a/types/splitio.d.ts b/types/splitio.d.ts
@@ -811,6 +811,7 @@ declare namespace SplitIO {
     label: string;
     changeNumber: number;
     pt?: number;
+    track?: boolean;
   }
   /**
    * Object with information about an impression. It contains the generated impression DTO as well as