Skip to content

Commit

Permalink
Merge branch 'redis_storage_improvements' into redis_clear_methods
Browse files Browse the repository at this point in the history
  • Loading branch information
EmilianoSanchez committed Nov 30, 2023
2 parents 355a4bd + d9cd9fd commit e555378
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
1.12.0 (December XX, 2023)
- Added support for Flag Sets in "consumer" and "partial consumer" modes for Pluggable and Redis storages.
- Updated evaluation flow to log a warning when using flag sets that don't contain cached feature flags.
- Updated Redis adapter to wrap missing commands: 'hincrby', 'popNRaw', and 'pipeline.exec'.
- Updated Redis adapter to handle timeouts and queueing of some missing commands: 'hincrby', 'popNRaw', and 'pipeline.exec'.
- Bugfixing - Fixed manager methods in consumer modes to return results in a promise when the SDK is not operational (not ready or destroyed).

1.11.0 (November 3, 2023)
Expand Down
4 changes: 2 additions & 2 deletions src/storages/inRedis/__tests__/SplitsCacheInRedis.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('SPLITS CACHE REDIS', () => {
expect(splits['lol1']).toEqual(null);
expect(splits['lol2']).toEqual(splitWithAccountTT);

// Teardown @TODO use cache clear method when implemented
// Teardown. @TODO use cache clear method when implemented
await connection.del(keysBuilder.buildTrafficTypeKey('account_tt'));
await connection.del(keysBuilder.buildSplitKey('lol2'));
await connection.del(keysBuilder.buildSplitsTillKey());
Expand Down Expand Up @@ -101,7 +101,7 @@ describe('SPLITS CACHE REDIS', () => {
expect(await cache.trafficTypeExists('account_tt')).toBe(true);
expect(await cache.trafficTypeExists('user_tt')).toBe(false);

// Teardown @TODO use cache clear method when implemented
// Teardown. @TODO use cache clear method when implemented
await connection.del(keysBuilder.buildTrafficTypeKey('account_tt'));
await connection.del(keysBuilder.buildSplitKey('malformed'));
await connection.del(keysBuilder.buildSplitKey('split1'));
Expand Down

0 comments on commit e555378

Please sign in to comment.