Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDKS-7801] Remove TotalFlagSets and InvalidSets for consumer mode #463

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[SDKS-7801] Remove TotalFlagSets and InvalidSets for consumer mode #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...nt/src/main/java/io/split/storages/pluggable/synchronizer/TelemetryConsumerSubmitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ ConfigConsumer generateConfig(SplitClientConfig splitClientConfig, Map<String, L
config.setActiveFactories(factoryInstances.size());
config.setRedundantFactories(getRedundantFactories(factoryInstances));
config.setTags(tags.size() < 10 ? tags : tags.subList(0, 10));
int invalidSets = splitClientConfig.getInvalidSets();
config.setFlagSetsTotal(splitClientConfig.getSetsFilter().size() + invalidSets);
config.setFlagSetsInvalid(invalidSets);
return config;
}

Expand Down
1 change: 0 additions & 1 deletion client/src/main/java/io/split/telemetry/synchronizer/HttpTelemetryMemorySender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import com.google.common.annotations.VisibleForTesting;
import io.split.client.dtos.UniqueKeys;
import io.split.client.utils.Utils;
import io.split.engine.segments.SegmentFetcherImp;
import io.split.service.HttpPostImp;
import io.split.telemetry.domain.Config;
import io.split.telemetry.domain.Stats;
Expand Down
1 change: 0 additions & 1 deletion client/src/main/java/io/split/telemetry/synchronizer/TelemetrySyncTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.split.telemetry.synchronizer;

import io.split.client.SplitClientConfig;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down
2 changes: 0 additions & 2 deletions ...rc/test/java/io/split/storages/pluggable/synchronizer/TelemetryConsumerSubmitterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ public void testSynchronizeConfig() {
ConfigConsumer config = telemetrySynchronizer.generateConfig(splitClientConfig, ApiKeyCounter.getApiKeyCounterInstance().getFactoryInstances(), Stream.of("tag1", "tag2").collect(Collectors.toList()));
Assert.assertEquals(3, config.getRedundantFactories());
Assert.assertEquals(2, config.getTags().size());
Assert.assertEquals(3, config.getFlagSetsTotal());
Assert.assertEquals(1, config.getFlagSetsInvalid());
}

@Test
Expand Down