New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDKS-7788] Some flag set fixes #462

Merged

nmayorsplit merged 1 commit into development from SDKS-7788

Nov 29, 2023

Contributor

nmayorsplit commented Nov 29, 2023

Updated to return null if the set doesn't have flags in getNamesByFlagSets
Assigned in flagSets if the sets are in the config, before getting all flags in getTreatmentsBySetsWithConfigInternal
Updated log:
Flag Set must adhere to the regular expressions {SetExpectedRegex}. This means a Flag Set must start with a letter or number, be in lowercase, alphanumeric and have a max length of 50 characters. {set} was discarded.
Added getTreaments without attributes param


          [SDKS-7788] Some flag set fixes

918d664

nmayorsplit requested a review from a team as a code owner

November 29, 2023 13:05

sonarqube-pull-requests bot commented Nov 29, 2023

SonarQube Quality Gate

Maintainability Rating on New Code (is worse than A)
29.4% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint in your IDE.

gthea approved these changes

View reviewed changes

nmayorsplit merged commit d5133eb into development

6 of 7 checks passed

nmayorsplit deleted the SDKS-7788 branch

November 29, 2023 17:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet