Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag sets release #458

Merged
merged 117 commits into from
Nov 2, 2023
Merged
Changes from 2 commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
9ff43e0
[SDKS-7514] Add flagSetFilter config
nmayorsplit Sep 6, 2023
69b7a63
Merge branch 'development' into SDKS-7514
nmayorsplit Sep 6, 2023
36d7327
[SDKS-7514] Create an empty list for flagsSetFilter
nmayorsplit Sep 7, 2023
fa765eb
WIP falg set sanitizer
nmayorsplit Sep 7, 2023
5d0269f
[SDKS-7516] Update FlagSetSanitizer
nmayorsplit Sep 8, 2023
90adbf0
Merge pull request #432 from splitio/SDKS-7514
nmayorsplit Sep 8, 2023
f3408a0
[SDKS-7516] Add test cases for FlagSetSanitizer
nmayorsplit Sep 8, 2023
1f93ec5
Changes after merge with development
nmayorsplit Sep 8, 2023
5cf7f8e
Merge branch 'SDKS-7439' into SDKS-7516
nmayorsplit Sep 8, 2023
00dc5d5
[SDKS-7516] Add FlagSetSanitizer in SplitClientConfig
nmayorsplit Sep 8, 2023
d7386d5
[SDKS-7516] Pr suggestions
nmayorsplit Sep 11, 2023
d94a7ba
[SDKS-7517] Add new property in Split dto
nmayorsplit Sep 11, 2023
2ab6c00
Merge pull request #436 from splitio/SDKS-7517
nmayorsplit Sep 11, 2023
2ecfc2a
Merge branch 'SDKS-7439' into SDKS-7516
nmayorsplit Sep 11, 2023
ca0c274
[SDKS-7516] Update after PR suggestions
nmayorsplit Sep 11, 2023
5d1d0e6
[SDKS-7516] Remove a log message
nmayorsplit Sep 11, 2023
084d42b
[SDKS-7520] Add sets in HttpSplitChangeFetcher and FetchOptions
nmayorsplit Sep 12, 2023
18afed7
[SDKS-7520] Add sets in equals method in FetchOptions
nmayorsplit Sep 12, 2023
77e3b23
[SDKS-7520] Add log error when the amount of flag sets provided are big
nmayorsplit Sep 14, 2023
1ff9b10
Merge pull request #435 from splitio/SDKS-7516
nmayorsplit Sep 14, 2023
7e53f8e
[SDKS-7520] Pr suggestion
nmayorsplit Sep 14, 2023
76476b1
Merge branch 'SDKS-7439' into SDKS-7520
nmayorsplit Sep 15, 2023
d319888
Merge pull request #437 from splitio/SDKS-7520
nmayorsplit Sep 15, 2023
f2318da
[SDKS-7521] Add falgSet logic in SplitFetcherImp
nmayorsplit Sep 15, 2023
0e14798
[SDKS-7521] Add test case for FeatureFlagProcessor
nmayorsplit Sep 18, 2023
7a534c6
[SDKS-7521] Add setFlags in SplitFetcherImp
nmayorsplit Sep 18, 2023
0422653
[SDKS-7521] Update FalgSetsFilter
nmayorsplit Sep 18, 2023
882441e
Merge pull request #438 from splitio/SDKS-7521
nmayorsplit Sep 18, 2023
d8b0f25
[SDKS-7518] Add getNamesByFlagSets in InMemoryCacheImp
nmayorsplit Sep 19, 2023
7226bcd
[SDKS-7519] Add in prefixAdapter sets and getMembers in CustomStorage…
nmayorsplit Sep 20, 2023
e77aa26
[SDKS-7518] Pr suggestions
nmayorsplit Sep 20, 2023
07d62f1
Merge pull request #439 from splitio/SDKS-7518
nmayorsplit Sep 20, 2023
a36b709
Merge branch 'SDKS-7439' into SDKS-7519
nmayorsplit Sep 20, 2023
f8571c8
[SDKS-7519] Add Add getNamesByFlagSets in UserCustomSplitAdapterConsumer
nmayorsplit Sep 22, 2023
03780e4
[SDKS-7523] Add sets in SplitView
nmayorsplit Sep 22, 2023
c891eb8
Pr suggestion
nmayorsplit Sep 22, 2023
56169c2
Merge pull request #441 from splitio/SDKS-7523
nmayorsplit Sep 22, 2023
b8fd789
Merge branch 'SDKS-7439' into SDKS-7519
nmayorsplit Sep 22, 2023
17be273
[SDKS-7519] Pr suggestions
nmayorsplit Sep 25, 2023
f9e7b53
Merge pull request #440 from splitio/SDKS-7519
nmayorsplit Sep 25, 2023
08faef6
[SDKS-7540] Create method EvaluateFeaturesByFlagSets in the Evaluator
nmayorsplit Sep 26, 2023
c7c04ec
Merge pull request #442 from splitio/SDKS-7540
nmayorsplit Sep 26, 2023
6af0b81
[SDKS-7541] Add getTreatments for sets
nmayorsplit Sep 28, 2023
cb8dacc
[SDKS-7537] Add flagSets in MethodLatencies
nmayorsplit Sep 29, 2023
67ac3c9
[SDKS-7541] Pr suggestions
nmayorsplit Sep 29, 2023
34c6f96
[SDKS-7537] Add sets in InMemoryTelemetryStorage
nmayorsplit Sep 29, 2023
49455e0
[SDKS-7541] Pr sugesstion
nmayorsplit Sep 29, 2023
589d223
[SDKS-7539] Add new exceptions in MethodExceptions
nmayorsplit Oct 2, 2023
b6a2588
Merge pull request #443 from splitio/SDKS-7541
nmayorsplit Oct 2, 2023
3b37861
Merge branch 'SDKS-7439' into SDKS-7537
nmayorsplit Oct 2, 2023
9aa7f7f
Merge branch 'SDKS-7439' into SDKS-7539
nmayorsplit Oct 2, 2023
02083c5
[SDKS-7539] Pr suggestions
nmayorsplit Oct 2, 2023
84093af
[SDKS-7537] Pr suggestions
nmayorsplit Oct 3, 2023
19eb33d
[SDKS-7537] Add test case for sets in stats
nmayorsplit Oct 3, 2023
1579f7c
[SDKS-7539] Add test case when pop exceptions
nmayorsplit Oct 3, 2023
6c34147
Merge pull request #445 from splitio/SDKS-7539
nmayorsplit Oct 3, 2023
7005510
After merge
nmayorsplit Oct 3, 2023
0d3a832
Merge pull request #444 from splitio/SDKS-7537
nmayorsplit Oct 3, 2023
8532a5a
[SDKS-7538] Add flag sets in Init Config
nmayorsplit Oct 4, 2023
a816701
[SDKS-7538] Add sets sort
nmayorsplit Oct 4, 2023
93087f3
[SDKS-7590] Add sests in SynchronizerImpl
nmayorsplit Oct 5, 2023
1c6a1ef
[SDKS-7538] Pr suggestion
nmayorsplit Oct 5, 2023
c236ecc
Merge pull request #446 from splitio/SDKS-7538
nmayorsplit Oct 5, 2023
fcf463a
Merge branch 'SDKS-7439' into SDKS-7590
nmayorsplit Oct 5, 2023
6cbfa6b
Update log message in FlagSetValidator
nmayorsplit Oct 9, 2023
5f1a471
Merge pull request #447 from splitio/SDKS-7590
nmayorsplit Oct 9, 2023
a5ebd3c
[SDKS-7589] Add Integration test for flag sets
nmayorsplit Oct 11, 2023
57a99fc
[SDKS-7589] Add test case for json localhost
nmayorsplit Oct 18, 2023
ed74371
Merge pull request #448 from splitio/SDKS-7589
nmayorsplit Oct 19, 2023
29766e7
[SDKS-7608] Fix calculate invalid flag sets
nmayorsplit Oct 19, 2023
e9da9a2
Pr suggestions
nmayorsplit Oct 19, 2023
0a5605c
Merge pull request #449 from splitio/SDKS-7608
nmayorsplit Oct 20, 2023
e57d00f
[SDKS-7608] Fix null pointer when a feature flag has a set that is no…
nmayorsplit Oct 20, 2023
f7ab2a8
[SDKS-7608] Add tests cases and pr suggestions
nmayorsplit Oct 20, 2023
947dda5
[SDKS-7676] Add ThreadFactory in the config builder
nmayorsplit Oct 23, 2023
cd16523
Merge pull request #450 from splitio/SDKS-7608
nmayorsplit Oct 23, 2023
7c28a58
Add test case
nmayorsplit Oct 23, 2023
47cff5b
Improve test cases
nmayorsplit Oct 23, 2023
7f04780
[SDKS-7639] Add defaultTreatment in SplitView
nmayorsplit Oct 23, 2023
1379948
[SDKS-7626] Add feature flag name in ready warning log
nmayorsplit Oct 23, 2023
9082fb9
[SDKS-7626] Pr suggestion
nmayorsplit Oct 23, 2023
1f7a755
Merge pull request #452 from splitio/SDKS-7639
nmayorsplit Oct 23, 2023
b337f0c
Merge branch 'development' into SDKS-7626
nmayorsplit Oct 23, 2023
7c16859
Merge pull request #453 from splitio/SDKS-7626
nmayorsplit Oct 23, 2023
483ca20
[SDKS-7676] Update unique key message
nmayorsplit Oct 24, 2023
541db29
Merge with development
nmayorsplit Oct 24, 2023
2df0f97
FalgSets improvements and fixes
nmayorsplit Oct 25, 2023
625e259
Pr suggestions
nmayorsplit Oct 26, 2023
bfed5aa
Remove ff from sets before to add and remove
nmayorsplit Oct 26, 2023
ec97b81
Move remove flags from sets before to call toAdd
nmayorsplit Oct 27, 2023
32793a9
Refactor code to can read it
nmayorsplit Oct 27, 2023
df83e49
Remo extra logs
nmayorsplit Oct 27, 2023
0b8a932
Change method names
nmayorsplit Oct 27, 2023
0e7f50f
Update version
nmayorsplit Oct 27, 2023
b5d8c02
Merge pull request #455 from splitio/flag-sets-improvements
nmayorsplit Oct 27, 2023
7bd580b
Merge branch 'development' into SDKS-7676
nmayorsplit Oct 27, 2023
fb66059
Merge pull request #451 from splitio/SDKS-7676
nmayorsplit Oct 27, 2023
c6ddd61
Merge with development
nmayorsplit Oct 27, 2023
747fcc8
[SDKS-7716] Add byFlagSet/s implementations that allow receiving matc…
nmayorsplit Oct 31, 2023
297bc06
[SDKS-7716] Remove extra comment
nmayorsplit Oct 31, 2023
b9fef3a
Remove imports not using
nmayorsplit Oct 31, 2023
33fa879
Add getTreatments in SplitClientForTest
nmayorsplit Oct 31, 2023
664245c
Merge pull request #456 from splitio/SDKS-7716
nmayorsplit Oct 31, 2023
c9f10c0
Create FlagSetFilter with empty sets in consumer mode
nmayorsplit Nov 1, 2023
393ab97
Improvements from sonarqube
nmayorsplit Nov 1, 2023
b7e30a6
Add message log const
nmayorsplit Nov 1, 2023
0bcb2f1
Merge branch 'SDKS-7439' into remove-flagsets-redis
nmayorsplit Nov 1, 2023
af162bc
Code smell from sonarqube
nmayorsplit Nov 1, 2023
b8eb7e0
Remove imports from EvaluatorImp
nmayorsplit Nov 1, 2023
c8ed1b9
Merge branch 'SDKS-7439' into remove-flagsets-redis
nmayorsplit Nov 1, 2023
0db82c9
Add change logs
nmayorsplit Nov 1, 2023
3fa9217
Update version in changelog
nmayorsplit Nov 1, 2023
6c9aecb
Update client/src/main/java/io/split/client/SplitFactoryImpl.java
nmayorsplit Nov 1, 2023
ac1beba
Merge pull request #457 from splitio/remove-flagsets-redis
nmayorsplit Nov 1, 2023
81392c8
Update version for tapps
nmayorsplit Nov 1, 2023
42be0f6
Update change logs and version
nmayorsplit Nov 2, 2023
09cd178
Merge pull request #454 from splitio/SDKS-7439
nmayorsplit Nov 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions client/src/main/java/io/split/client/api/SplitView.java
Original file line number Diff line number Diff line change
@@ -24,13 +24,15 @@ public class SplitView {
public List<String> treatments;
public long changeNumber;
public Map<String, String> configs;
public String defaultTreatment;

public static SplitView fromParsedSplit(ParsedSplit parsedSplit) {
SplitView splitView = new SplitView();
splitView.name = parsedSplit.feature();
splitView.trafficType = parsedSplit.trafficTypeName();
splitView.killed = parsedSplit.killed();
splitView.changeNumber = parsedSplit.changeNumber();
splitView.defaultTreatment = parsedSplit.defaultTreatment();

Set<String> treatments = new HashSet<String>();
for (ParsedCondition condition : parsedSplit.parsedConditions()) {
Original file line number Diff line number Diff line change
@@ -67,6 +67,7 @@ public void splitCallWithExistentSplit() {
Assert.assertEquals(1, theOne.treatments.size());
Assert.assertEquals("off", theOne.treatments.get(0));
Assert.assertEquals(0, theOne.configs.size());
Assert.assertEquals("off", theOne.defaultTreatment);
}

@Test