Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FlagSetFilter with empty sets in consumer mode #457

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Create FlagSetFilter with empty sets in consumer mode #457

merged 4 commits into from
Nov 1, 2023

Conversation

nmayorsplit
Copy link
Contributor

No description provided.

@nmayorsplit nmayorsplit requested a review from a team as a code owner November 1, 2023 15:25
gthea
gthea approved these changes Nov 1, 2023
View reviewed changes
client/src/main/java/io/split/client/SplitFactoryImpl.java Outdated Show resolved Hide resolved
client/src/main/java/io/split/client/interceptors/FlagSetsFilter.java
Comment on lines +7 to +8
boolean intersect(Set<String> sets);
boolean intersect(String set);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmayorsplit nmayorsplit merged commit ac1beba into SDKS-7439 Nov 1, 2023
2 of 3 checks passed
@nmayorsplit nmayorsplit deleted the remove-flagsets-redis branch November 1, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthea gthea gthea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmayorsplit @gthea